On 04/11/2014 02:12 PM, Sopot Çela
wrote:
Hi,
I'm trying to use the SWTBot generator on a couple of pure
Eclipse 4 RCP apps I have and it's not working (it's not
starting at all). I noticed the generator depends on
org.eclipse.ui which drags all the 3.x dependencies, although
I feel they're not always needed. I think the only dependency
on the 3.x is the way it is activated (AbstractUIPlugin) and
something related to the IPartListener2. I'd like to remove
all dependencies to org.eclipse.ui in order just to use a
plain generator (no JDT support etc.). Do you think I'm being
too optimistic about the effort?
Ideally the "plain" SWTBot recorder should only depend on SWT in
order to run in all contexts supported by SWTBot APIs. So your idea
definitely makes sense.
I have the feeling it would be a small workload to remove
dependencies to non-SWT APIs from org.eclipse.swtbot.generator
bundle. So you can be optimistic ;)
Are you interested in a contribution in the main codebase
or should I fork everything ?
I don't see any reason why not making this change in the codebase
for the simple generator. So feel free to provide patches via
Gerrit. More details at http://wiki.eclipse.org/SWTBot/Contributing
We can have an o.e.swtbot.e4.generator initially so I don't
mess with the existing one. This can be used for Eclipse 4
RCPs with no compat layer (like mine).
If you had a dependency on some e4 stuff, then it will indeed
require a specific new plugin.
If your idea is just to remove dependencies, it's OK to make it in
the current one.
It can be a bit of both.
HTH
|