Test locations (was: Re: [stp-dev] Commit: build/ - Code commit guidelin

[Oisin Hurley <ohurley@xxxxxxxx>]

Just to summarize some of the discussion that has gone on re
this topic.

The two positions I'll illustrate with a dir structure:

1. David + Alex

    /sc
         /features
             /org.eclipse.stp.sc
         /plugins
             /org.eclipse.stp.sc.ui   <-- plugin id
             /org.eclipse.stp.sc.core
            ..
        /tests
             /org.eclipse.stp.sc.tests.ui   <-- fragment id
                /org.eclipse.stp.sc.ui      <-- java package same as  
tested plugin
             /org.eclipse.stp.sc.tests.core

2. Dan + Naci + Eclipse (!)

    /sc
         /features
             /org.eclipse.stp.sc
         /plugins
             /org.eclipse.stp.sc.ui  <-- plugin id
             /org.eclipse.stp.sc.core
            ..
        /tests
             /org.eclipse.stp.sc.tests.ui      <-- fragment id
                /org.eclipse.stp.sc.tests.ui   <-- java package  
different to tested plugin
             /org.eclipse.stp.sc.tests.core

Summary -- the java packages in the test fragment are the *same* as
the java packages in the tested plugin (1) or they are different,
with the package el 'tests' in there as per convention.

The reasoning behind (1) is a practical consideration that you can
test package protected stuff, however (2) is considered the eclipse
conventional approach.

So - what's the best approach? Maybe we can bring out the pros and  
cons on the
IRC today.

 rgds
   --oh