Stuart McCulloch <mcculls@xxxxxxxxx> wrote on
30/09/2013 12.46.42:
> For the moment I think
it's better to separate out these changes
> rather than roll them all into this refactoring item; we can discuss
> them in a separate patch/issue (will be easier for people to follow).
Ok, I will rollback to checking for
import "javax.inject" and "com.google.inject" as it
was in the original implementation.
I will also rollback the change in the
algorithm to select bean scanning.
Do you still want the method moved from
Main to BeanScanning? (To me it seems a better location.)
Yes - ideally a valueOf method to go from String->BeanScanning, plus a method to go from property map->BeanScanning (which uses the valueOf method) > I proposed a change to make
> the selection of an extendable bundle pluggable. Very simple, based
> on an interface + default implementation which can be overriden by
> means of a system property + fragment attached to the sisu bundle.
>
> Sounds reasonable to me.
Good.
> If you can wait one or two days
before merging, I can try to make
> the change: I could make the service tracker look for
> BindingPublisher in the OSGi registry, and have the bundle tracker
> register an InjectorPublisher.
>
> No problem, go ahead.
Thanks.
> This is another item that's best
addressed in a separate follow-up
> patch, then we can link it to https://bugs.eclipse.
> org/bugs/show_bug.cgi?id=394734 rather than have multiple features
> going into a single patch.
Ok.
>> Just let me know if you can
wait and want me to remove it.
>
> Sure, zap it :)
Ok.
To recap, I will:
- roll back the code to select an extendable
bundle, but leave the behaviour pluggable;
- roll back the code to select the bean
scanning (but still move the method from Main to BeanScanning?)
- change from requiring a Provider<Injector>
and implementing that interface to requiring BindingPublisher and using
InjectorPublisher
- delete BundleProperties and use System.getProperties().
Thanks While
- possible improvement to the BeanScanning
selection will be addressed by a separate patch, probably related to #394734.
- possible improvements to the default
strategy for selecting an extendable bundle will be addressed by a separate
bugzilla entry and a related patch.
At this point I suppose you want the
the last two items to be postponed to a later release, correct?
Yes at this stage I don't want to delay submission of the IP log by too much (as it takes them a while to review it). GianMaria.
|
