sisu-dev http://dev.eclipse.org/mhonarc/lists/sisu-dev/maillist.html sisu-dev en-us Fri, 02 Mar 2012 17:50:03 GMT Fri, 02 Mar 2012 17:50:03 GMT http://blogs.law.harvard.edu/tech/rss MHonArc RSS 2.0 RCFile webmaster@eclipse.org (Webmaster) webmaster@eclipse.org (Webmaster) sisu-dev http://www.eclipse.org/eclipse.org-common/themes/Phoenix/images/eclipse_home_header.jpg http://dev.eclipse.org/mhonarc/lists/sisu-dev/maillist.html [sisu-dev] Initial contributions http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00008.html Hi folks,Brief update of where things stand... I've logged two contributions - one for Sisu's new parent pom.xml: https://bugs.eclipse.org/bugs/show_bug.cgi?id=372080and another containing the JSR330 (non-Plexus) extension code from https://github.com/so... Hi folks,

Brief update of where things stand... I've logged two contributions - one for Sisu's new parent pom.xml:

   https://bugs.eclipse.org/bugs/show_bug.cgi?id=372080

and another containing the JSR330 (non-Plexus) extension code from https://github.com/sonatype/sisu

   https://bugs.eclipse.org/bugs/show_bug.cgi?id=372081

Once approved these contributions should eventually end up in the following GIT repos (not yet created):

   http://git.eclipse.org/c/sisu/org.eclipse.sisu.parent.git

   http://git.eclipse.org/c/sisu/org.eclipse.sisu.inject.git

The "org.eclipse.sisu.inject" contribution is everything that was under https://github.com/sonatype/sisu/tree/master/sisu-inject/containers/guice-bean except that I merged it into a single source tree, refactored the packages, updated the headers, and removed a local copy of some ASM code - I also removed some test zips/jars (because the initial contribution shouldn't contain embedded archives). Note that while these changes are enough for the initial contribution, once this is safely in git I want to take advantage of the necessary package change to go further and clean up the overall API to make it easier to extend and re-use the code.

I'm thinking of using the following layout for the cleanup:

   org.eclipse.sisu.inject   #  client API  --  org.eclipse.sisu is another option, but perhaps that's too general?
     \---spi                 #  provider SPI
     \---scan                #  class-path-scanning
     \---find                #  component lookup
     \---bind                #  auto-binding logic
     \---boot                #  container support
     \---util                #  utility code

But this is not cast in stone - other suggestions are welcome!

While we're stabilizing the JSR330 extension code, I'll start another contribution for the Plexus adapter. This will contain everything under https://github.com/sonatype/sisu/tree/master/sisu-inject/containers/guice-plexus except the bit that contains the thin "org.codehaus.plexus" shim. This package will need to be hosted outside of Eclipse because it has an external namespace. We should also consider providing a similar thin adapter for users of the "org.sonatype.inject" API, again this will need to be hosted outside of Eclipse perhaps using the original "org.sonatype.sisu:sisu-inject-bean" maven coordinate?

Other things on the long-term plan - finish the binding registries for OSGi services / Eclipse extensions, and support JSR250 annotations @PostConstruct / @PreDestroy :)

--
Cheers, Stuart
]]> Fri, 02 Mar 2012 17:45:53 GMT http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00008.html mcculls@xxxxxxx (Stuart McCulloch) Re: [sisu-dev] when is Disposable.dipose() supposed to be called? http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00007.html Yes - the Plexus container can be embedded in all sorts of environments so it relies on the embedding/hosting code (in this case Maven) to properly dispose of the container. _______________________________________________ sisu-dev mailing list sisu-dev@xx... created http://jira.codehaus.org/browse/MNG-5206 -----Original Message----- From: sisu-dev-bounces@xxxxxxxxxxx [mailto:sisu-dev-bounces@xxxxxxxxxxx] On Behalf Of Stuart McCulloch Sent: Mittwoch, 30. November 2011 11:00 To: Sisu project developer discussions Cc: Sisu project developer discussions Subject: Re: [sisu-dev] when is Disposable.dipose() supposed to be called? On 30 Nov 2011, at 09:50, "Sievers, Jan" <jan.sievers@xxxxxxx> wrote: > OK. Since I am using plexus in maven, should maven take care of disposing the container e.g. when the maven session ends? Yes - the Plexus container can be embedded in all sorts of environments so it relies on the embedding/hosting code (in this case Maven) to properly dispose of the container. > Somehow I don't feel like this is something I should handle myself... > > Regards, > Jan > > -----Original Message----- > From: sisu-dev-bounces@xxxxxxxxxxx [mailto:sisu-dev-bounces@xxxxxxxxxxx] On Behalf Of Stuart McCulloch > Sent: Mittwoch, 30. November 2011 10:42 > To: Sisu project developer discussions > Cc: sisu-dev@xxxxxxxxxxx > Subject: Re: [sisu-dev] when is Disposable.dipose() supposed to be called? > > On 30 Nov 2011, at 09:06, "Sievers, Jan" <jan.sievers@xxxxxxx> wrote: > >> Hi, >> >> in tycho we have a plexus component which implements Disposable, see [1]. >> >> I want some cleanup work to be done in dispose() but it seems this method is never called. > > Hi Jan, > > Disposables are only called when the Plexus container is itself disposed or when someone explicitly calls the container to release the component (or the map/list containing the component). > > If it is not getting called then that suggests no-one is disposing of the container. (Sisu-)Plexus will only act on container.dispose() - it doesn't install any shutdown hooks itself or use any form of GC/finalization to track when a component is no longer alive. > > -- > Cheers, Stuart > >> Any hints what I could be doing wrong? >> >> Regards, >> Jan >> >> [1] http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/sisu-equinox/sisu-equinox-embedder/src/main/java/org/eclipse/sisu/equinox/embedder/internal/DefaultEquinoxEmbedder.java >> _______________________________________________ >> sisu-dev mailing list >> sisu-dev@xxxxxxxxxxx >> http://dev.eclipse.org/mailman/listinfo/sisu-dev > _______________________________________________ > sisu-dev mailing list > sisu-dev@xxxxxxxxxxx > http://dev.eclipse.org/mailman/listinfo/sisu-dev > _______________________________________________ > sisu-dev mailing list > sisu-dev@xxxxxxxxxxx > http://dev.eclipse.org/mailman/listinfo/sisu-dev _______________________________________________ sisu-dev mailing list sisu-dev@xxxxxxxxxxx http://dev.eclipse.org/mailman/listinfo/sisu-dev ]]> Wed, 30 Nov 2011 10:34:33 GMT http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00007.html jan.sievers@xxxxxxx (Sievers, Jan) Re: [sisu-dev] when is Disposable.dipose() supposed to be called? http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00006.html Yes - the Plexus container can be embedded in all sorts of environments so it relies on the embedding/hosting code (in this case Maven) to properly dispose of the container. On 30 Nov 2011, at 09:50, "Sievers, Jan" <jan.sievers@xxxxxxx> wrote: > OK. Since I am using plexus in maven, should maven take care of disposing the container e.g. when the maven session ends? Yes - the Plexus container can be embedded in all sorts of environments so it relies on the embedding/hosting code (in this case Maven) to properly dispose of the container. > Somehow I don't feel like this is something I should handle myself... > > Regards, > Jan > > -----Original Message----- > From: sisu-dev-bounces@xxxxxxxxxxx [mailto:sisu-dev-bounces@xxxxxxxxxxx] On Behalf Of Stuart McCulloch > Sent: Mittwoch, 30. November 2011 10:42 > To: Sisu project developer discussions > Cc: sisu-dev@xxxxxxxxxxx > Subject: Re: [sisu-dev] when is Disposable.dipose() supposed to be called? > > On 30 Nov 2011, at 09:06, "Sievers, Jan" <jan.sievers@xxxxxxx> wrote: > >> Hi, >> >> in tycho we have a plexus component which implements Disposable, see [1]. >> >> I want some cleanup work to be done in dispose() but it seems this method is never called. > > Hi Jan, > > Disposables are only called when the Plexus container is itself disposed or when someone explicitly calls the container to release the component (or the map/list containing the component). > > If it is not getting called then that suggests no-one is disposing of the container. (Sisu-)Plexus will only act on container.dispose() - it doesn't install any shutdown hooks itself or use any form of GC/finalization to track when a component is no longer alive. > > -- > Cheers, Stuart > >> Any hints what I could be doing wrong? >> >> Regards, >> Jan >> >> [1] http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/sisu-equinox/sisu-equinox-embedder/src/main/java/org/eclipse/sisu/equinox/embedder/internal/DefaultEquinoxEmbedder.java >> _______________________________________________ >> sisu-dev mailing list >> sisu-dev@xxxxxxxxxxx >> http://dev.eclipse.org/mailman/listinfo/sisu-dev > _______________________________________________ > sisu-dev mailing list > sisu-dev@xxxxxxxxxxx > http://dev.eclipse.org/mailman/listinfo/sisu-dev > _______________________________________________ > sisu-dev mailing list > sisu-dev@xxxxxxxxxxx > http://dev.eclipse.org/mailman/listinfo/sisu-dev ]]> Wed, 30 Nov 2011 10:00:12 GMT http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00006.html mcculls@xxxxxxx (Stuart McCulloch) Re: [sisu-dev] when is Disposable.dipose() supposed to be called? http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00005.html Hi Jan, Disposables are only called when the Plexus container is itself disposed or when someone explicitly calls the container to release the component (or the map/list containing the component). If it is not getting called then that suggests no-one is d... OK. Since I am using plexus in maven, should maven take care of disposing the container e.g. when the maven session ends? Somehow I don't feel like this is something I should handle myself... Regards, Jan -----Original Message----- From: sisu-dev-bounces@xxxxxxxxxxx [mailto:sisu-dev-bounces@xxxxxxxxxxx] On Behalf Of Stuart McCulloch Sent: Mittwoch, 30. November 2011 10:42 To: Sisu project developer discussions Cc: sisu-dev@xxxxxxxxxxx Subject: Re: [sisu-dev] when is Disposable.dipose() supposed to be called? On 30 Nov 2011, at 09:06, "Sievers, Jan" <jan.sievers@xxxxxxx> wrote: > Hi, > > in tycho we have a plexus component which implements Disposable, see [1]. > > I want some cleanup work to be done in dispose() but it seems this method is never called. Hi Jan, Disposables are only called when the Plexus container is itself disposed or when someone explicitly calls the container to release the component (or the map/list containing the component). If it is not getting called then that suggests no-one is disposing of the container. (Sisu-)Plexus will only act on container.dispose() - it doesn't install any shutdown hooks itself or use any form of GC/finalization to track when a component is no longer alive. -- Cheers, Stuart > Any hints what I could be doing wrong? > > Regards, > Jan > > [1] http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/sisu-equinox/sisu-equinox-embedder/src/main/java/org/eclipse/sisu/equinox/embedder/internal/DefaultEquinoxEmbedder.java > _______________________________________________ > sisu-dev mailing list > sisu-dev@xxxxxxxxxxx > http://dev.eclipse.org/mailman/listinfo/sisu-dev _______________________________________________ sisu-dev mailing list sisu-dev@xxxxxxxxxxx http://dev.eclipse.org/mailman/listinfo/sisu-dev ]]> Wed, 30 Nov 2011 09:50:45 GMT http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00005.html jan.sievers@xxxxxxx (Sievers, Jan) Re: [sisu-dev] when is Disposable.dipose() supposed to be called? http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00004.html _______________________________________________ sisu-dev mailing list sisu-dev@xxxxxxxxxxx http://dev.eclipse.org/mailman/listinfo/sisu-dev ? -----Original Message----- From: sisu-dev-bounces@xxxxxxxxxxx [mailto:sisu-dev-bounces@xxxxxxxxxxx] On Behalf Of Stuart McCulloch Sent: Mittwoch, 30. November 2011 10:34 To: Sisu project developer discussions Cc: sisu-dev@xxxxxxxxxxx Subject: Re: [sisu-dev] when is Disposable.dipose() supposed to be called? -- Cheers, Stuart On 30 Nov 2011, at 09:06, "Sievers, Jan" <jan.sievers@xxxxxxx> wrote: > Hi, > > in tycho we have a plexus component which implements Disposable, see [1]. > > I want some cleanup work to be done in dispose() but it seems this method is never called. > > Any hints what I could be doing wrong? > > Regards, > Jan > > [1] http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/sisu-equinox/sisu-equinox-embedder/src/main/java/org/eclipse/sisu/equinox/embedder/internal/DefaultEquinoxEmbedder.java > _______________________________________________ > sisu-dev mailing list > sisu-dev@xxxxxxxxxxx > http://dev.eclipse.org/mailman/listinfo/sisu-dev _______________________________________________ sisu-dev mailing list sisu-dev@xxxxxxxxxxx http://dev.eclipse.org/mailman/listinfo/sisu-dev ]]> Wed, 30 Nov 2011 09:42:30 GMT http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00004.html jan.sievers@xxxxxxx (Sievers, Jan) Re: [sisu-dev] when is Disposable.dipose() supposed to be called? http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00003.html Hi Jan, Disposables are only called when the Plexus container is itself disposed or when someone explicitly calls the container to release the component (or the map/list containing the component). If it is not getting called then that suggests no-one is d... On 30 Nov 2011, at 09:06, "Sievers, Jan" <jan.sievers@xxxxxxx> wrote: > Hi, > > in tycho we have a plexus component which implements Disposable, see [1]. > > I want some cleanup work to be done in dispose() but it seems this method is never called. Hi Jan, Disposables are only called when the Plexus container is itself disposed or when someone explicitly calls the container to release the component (or the map/list containing the component). If it is not getting called then that suggests no-one is disposing of the container. (Sisu-)Plexus will only act on container.dispose() - it doesn't install any shutdown hooks itself or use any form of GC/finalization to track when a component is no longer alive. -- Cheers, Stuart > Any hints what I could be doing wrong? > > Regards, > Jan > > [1] http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/sisu-equinox/sisu-equinox-embedder/src/main/java/org/eclipse/sisu/equinox/embedder/internal/DefaultEquinoxEmbedder.java > _______________________________________________ > sisu-dev mailing list > sisu-dev@xxxxxxxxxxx > http://dev.eclipse.org/mailman/listinfo/sisu-dev ]]> Wed, 30 Nov 2011 09:42:09 GMT http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00003.html mcculls@xxxxxxx (Stuart McCulloch) Re: [sisu-dev] when is Disposable.dipose() supposed to be called? http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00002.html -- Cheers, Stuart On 30 Nov 2011, at 09:06, "Sievers, Jan" <jan.sievers@xxxxxxx> wrote: > Hi, > > in tycho we have a plexus component which implements Disposable, see [1]. > > I want some cleanup work to be done in dispose() but it seems this method is never called. > > Any hints what I could be doing wrong? > > Regards, > Jan > > [1] http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/sisu-equinox/sisu-equinox-embedder/src/main/java/org/eclipse/sisu/equinox/embedder/internal/DefaultEquinoxEmbedder.java > _______________________________________________ > sisu-dev mailing list > sisu-dev@xxxxxxxxxxx > http://dev.eclipse.org/mailman/listinfo/sisu-dev ]]> Wed, 30 Nov 2011 09:33:47 GMT http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00002.html mcculls@xxxxxxx (Stuart McCulloch) [sisu-dev] when is Disposable.dipose() supposed to be called? http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00001.html Hi, in tycho we have a plexus component which implements Disposable, see [1]. I want some cleanup work to be done in dispose() but it seems this method is never called. Any hints what I could be doing wrong? Regards, Jan [1] http://git.eclipse.org/c/tycho/... Hi, in tycho we have a plexus component which implements Disposable, see [1]. I want some cleanup work to be done in dispose() but it seems this method is never called. Any hints what I could be doing wrong? Regards, Jan [1] http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/sisu-equinox/sisu-equinox-embedder/src/main/java/org/eclipse/sisu/equinox/embedder/internal/DefaultEquinoxEmbedder.java ]]> Wed, 30 Nov 2011 09:06:08 GMT http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00001.html jan.sievers@xxxxxxx (Sievers, Jan) Welcome to sisu-dev http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00000.html Welcome to the sisu-dev mailing list. -Webmaster. Welcome to the sisu-dev mailing list. -Webmaster.]]> Thu, 22 Sep 2011 13:44:54 GMT http://dev.eclipse.org/mhonarc/lists/sisu-dev/msg00000.html Webmaster@xxxxxxx (portal on behalf of emo)