[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [sequoyah-dev] Fix for LFE - blank spaces in keys

This is a valuable fix to the Android build chain, I wonder if we are
better off installing a set of properties as key/value pairs in the
base class and overriding them as necessary in the child classes.
Then, as we add new properties, we don't need to break the API
contract, we just need to add another key.

Granted, I'm not adept at Eclipse plugin writing, but I would think
something like boolean getProperty(String key, String &value); would
have a better long-term potential.

Comments?

-E

On Mon, Oct 18, 2010 at 6:58 AM, Vinicius Hernandes <XRGC84@xxxxxxxxxxxx> wrote:
> Hi Guys,
> I opened a bug for the LFE (#327924) and submitted a patch to fix it.
> The problem:
>
> The LFE allow users to add keys with blank spaces on it. However, in most
> cases this might not be allowed. The reference implementation itself is an
> example: you will broke your Android project if you add a key with blank
> spaces on it, .
>
> The solution:
>
> A new abstract method was added to ILocalizationSchema  [boolean
> keyAcceptsBlankSpaces()]. All localization schemas must implement this
> method, returning true if keys with blank spaces are permitted in that
> schema or false otherwise. The "New key" dialog was also modified to
> validate that accordingly, displaying a message to the user in case the key
> has blank spaces but it's not permitted.
>
> Am I correct? Please advise.
> Regards,
> Vinicius
> _______________________________________________
> sequoyah-dev mailing list
> sequoyah-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/sequoyah-dev
>
>



-- 
Eric Cloninger (ericc@xxxxxxxxxxxx)
Senior Product Manager, MOTODEV Studio for Android
Eclipse Sequoyah Project Lead