[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [sapphire-dev] recent diagram page propertypage changes
|
Looking some more in SapphireDiagramEditor#selectionChanged() it is checking for editorPartIsActive. However if you have a propertyPage that has mulitple tabs and you switch tabs, this will fire a workbench selection changed so when selectionChanged() is called again the editorIsActive however it is not the activePart, the PropertySheetView is the active part. Perhaps the call on line 509 should look like this instead?
boolean editorPartIsActive = getSite().getPage().getActivePart().equals( this );
And then line 516 could be:
editorPartIsActive = getSite().getPage().getActivePart().equals( activeEditor );
Thanks for taking a look at this.
On Fri, May 11, 2012 at 2:50 PM, Greg Amerson
<gregory.amerson@xxxxxxxxxxx> wrote:
Hey guys,
Just FYI, some changes in one of the recent builds (maybe 226 or 227?) seems to have broken changing tabs on property page tabs. So if in diagram editor you click on a node that has multiple property page contributions (multiple tabs) and then you change the tab, the propertySheet will immediately go blank. Do you see that in your environments? Thanks for checking.
--
Greg Amerson
Liferay, Inc.
---
--
Greg Amerson
Liferay, Inc.
---
