| Re: [sapphire-dev] duplicated sapphire-extension.xml |
I wish Eclipse IP policy made it possible for you to contribute patches this late in the release as it sounds like you’ve done the difficult work of figuring out what is causing this behavior. A simple de-duplication step should fix this indeed. Please open a bug. I checked with EMO and we can get IP log re-reviewed for service releases (0.3.1, etc.), so you will be able to contribute patches again very soon. Keep that up and we will make you a committer on the project. - Konstantin From: sapphire-dev-bounces@xxxxxxxxxxx [mailto:sapphire-dev-bounces@xxxxxxxxxxx] On Behalf Of Greg Amerson Konstantin, I know you and the other commiters are super busy, so I did some more debugging, it has something to do with buddy loading. BundleLoader#findResources() line 709, is returning my sapphire-extension.xml even from the "emf.ecore" BundleLoader so I guess my plugin along with those 3 others are in the buddy policy that is returning it from the getResources() call. So perhaps the ExtensionsLocatorFactory could do a small bit of checking to make sure that we don't have add new Handle() object where there has already been a Handle added that holds that same URL. I'll leave the rest of the analysis to the experts now. :) On Wed, Jun 8, 2011 at 12:09 PM, Greg Amerson <gregory.amerson@xxxxxxxxxxx> wrote: Hey everyone, I'm trying to add a action to the root context menu for diagrams. I've specified a new action and action handler in the META-INF/sapphire-extension.xml (attached). However, I'm seeing some weird behavior where Sapphire is reading my extension file twice. This is causing my toggle action to be listed 2x in the context menu as a submenu even (see attached screenshot). I debugged the ExtensionsLocatorFactory and it returns my exact bundle URL to my sapphire-extension.xml from two different bundleHosts. My own plugin and also org.eclipse.emf.ecore. Actually the extension locator find() method shows that emf.ecore is returning 4 duplicated URLs, my own sapphire-extension.xml and also 3 other duplicated URLs, sapphire.samples, sapphire.swt.graphiti and sapphire.sdk bundles. Any ideas why the ExtensionsLocatorFactory is returning my sapphire-extension.xml from both my own bundle and oddly enough from the org.eclipse.emf.ecore bundle? Greg Amerson (@greg_amerson) Liferay, Inc. (#liferay)
Greg Amerson (@greg_amerson) Liferay, Inc. (#liferay) |