Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [sapphire-dev] diagram page context menu

Shenxue,

 

These type of discussions should always go through the mailing list.

 

When is the next Graphiti milestone due?

 

- Konstantin

 

From: Shenxue Zhou [mailto:shenxue.zhou@xxxxxxxxxx]
Sent: Thursday, May 12, 2011 10:55 AM
To: Konstantin Komissarchik
Subject: diagram page context menu

 

Hi Konstantine,

 

Graphiti team has accepted my patch to disallow other plugins to contribute to the diagram page context menu. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=345347

 

The patch is checked into the Head. I just found out that it's not possible for me to copy-paste code to override Graphiti Editor's default behavior. The method I need to override is the following menthod:

@Override

protected void initializeGraphicalViewer() {

super.initializeGraphicalViewer();

 

Notice its call to its super's initializeGraphicalViewer() method. In my editor subclass, I can't call super's initializeGraphicalViewer() which means the grandparent's initilizeGraphicalViewer() won't be called. That will result in incorrect-behavior.

There are only two options: use Graphiti's nightly build in our build systems to get my patch; or just wait a new milestone of Graphiti and live with context menus contributed by other plugins.

PS: The benpoint move bug has also been fixed.

Which do you prefer?

 


Back to the top