Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[rt-pmc] Re: [jetty-dev] Eclipse and JSP


On 29-Jul-09, at 11:57 AM, Jesse McConnell wrote:

In my opinion this pmc should recommend a jsp implementation for use
throughout the eclipse platform that meets muster from the IP
perspective and yet allows for users to patch if needed for core bug
fixes and extension points for those that need them.

It is not really for the PMC to recommend technical solutions. That should really come from the relevant projects. In this case I'd be more than happy to see Jetty say "XXX is the best JSP impl to use" and then we pursue that through the IP process. if there are impls that are more or less IP friendly that may factor into the recommendation as this IP thing will be ongoing if we are consuming updates from the original origin.

As you are probably aware now, jetty has chosen the glassfish jasper
fork as the core source that we minorly patch and release artifacts
for use in jetty.  The CQ's related to this are pending now so that we
can review this approach and perhaps adopt a more eclipse wide
solution that more folks can make use of.

To that end my initial recommendation would be to have the glassfish
source that we use run through the IP process

+1

and then setup a project
in eclipse svn (org.eclipse.jsp under RT perhaps) that we then import
the source into and massage into the format we want.

I suggest that we just put it in the Jetty project. No real need to start a new project for this. It is logically part of Jetty in the Eclipse context and is indeed, your cut on JSP support so...

I would be more
then happy to make sure these things could be built and deployed in
the existing maven infrastructure in the short term while the eclipse
organization comes to terms with how it will support maven projects
better, so long as someone else could volunteer to help in making the
eclipse orbit oriented artifacts as well.

If you are getting source from someplace, hacking on it, building it and shipping it, it does not need to come from or be put in Orbit. You would have Jetty that *produces* JSP support. (period). That is one of the outputs of the Jetty project. The fact that you did that by getting source code from somewhere else, hacking on it etc is immaterial (as long as the acquisition of the third party source was approved through the IP process).

With this sort of structure
in place I would suggest that we keep it incrementally updated with
new tags as glassfish folks patch and update their jasper fork until
such time there is some global unified effort to bring all the jasper
forks back under home, should that ever happen of course.

You are essentially driving your own fork of the glassfish JSP support now and would continue to do so. You would, as you do now, periodically get updates from glassfish and merge them all or in part into your code stream. The difference is that before getting the new glassfish stuff you have to do a CQ for the new code.

Make sense?

Jeff


Back to the top