Hi Elias,
thank you for making this list! Very helpful! Most of this stuff appears to be leftovers of Rienas predecessor that got migrated but a) is not needed for or already exist on the RCP/SWT platform or b) is not yet implemented for Riena. For both cases I agree that we should remove the unused stuff now. We can add the b)-cases again once they are implemented - now they are only confusing users and unnecessarily constraining the development.
I wonder how:
org.eclipse.riena.ui.uibinding.* - 6 intefaces and classes
made it on the list. The 6 files in this package are still used and should not be removed. :-)
But I can confirm that everything else is unused:
IActionCallback
IComboEntryFactory
ICursor
IMatrixRidget
IMenuFactory
IMenuSeparator
IMenuSpacer
IRadioButtonRidget
IStatuslineProcessRidget
ITabbedPaneRidget
ITabbedPaneRidgetListener
IWindowClosingPolicy
IWindowListener
org.eclipse.riena.ui.ridgets.tree.* - 25 interfaces and classes
org.eclipse.riena.ui.ridgets.treetable.* - 7 interfaces and classes
org.eclipse.riena.ui.util.* - 2 intefaces
Stuff from the packages "tree" and "treetable" is used only in deprecated methods elsewhere except that the interface IObservableTreeModel is returned by the method ITreeRidget.getRidgetObservable() which is not yet deprecated. But this deprecation was obviously just overlooked since the return type IObservableTreeModel is already deprecated. So I think it is ok to remove these two packages.
Following that it would be cool if the package "tree2" could be renamed to "tree" but I think this would break to much now...
Greetings,
Carsten
Von:
riena-dev-bounces@xxxxxxxxxxx [
mailto:riena-dev-bounces@xxxxxxxxxxx] Im Auftrag von Elias Volanakis
Gesendet: Mittwoch, 29. April 2009 22:58
An: Riena Developers list
Betreff: [riena-dev] Unused Stuff in org.eclipse.riena.ui.ridgets -- was Re: Ok to remove IMatrixRidget?
After a quick investigation it appears that the several interfaces / classes, listed below, are unused by the SWT stuff I've in my workspace.
These are currently provisional API and I am wondering what to do about them.
- Personally I favor removal, because it will make it easier for the users (developers) to figure out which stuff is actually backed by an implementation.
- If we don't want to remove my second preference would be to mark as deprecated:
@deprecated - currently unused
Personally I would have doubts about make the org.eclipse.riena.ui.ridgets bundle non-provisional, before discussing this.
Just my 2c,
Elias.
IActionCallback
IComboEntryFactory
ICursor
IMatrixRidget
IMenuFactory
IMenuSeparator
IMenuSpacer
IRadioButtonRidget
IStatuslineProcessRidget
ITabbedPaneRidget
ITabbedPaneRidgetListener
IWindowClosingPolicy
IWindowListener
org.eclipse.riena.ui.ridgets.tree.* - 25 interfaces and classes
org.eclipse.riena.ui.ridgets.treetable.* - 7 interfaces and classes
org.eclipse.riena.ui.uibinding.* - 6 intefaces and classes
org.eclipse.riena.ui.util.* - 2 intefaces
On Wed, Apr 29, 2009 at 1:22 PM, Elias Volanakis <
elias@xxxxxxxxxxxxxxxxx> wrote:
I'm updating the javadoc (272595) and found out that IMatrixRidget is not used anywhere (i.e. no implementation).
Any vetoes against removing it?
Elias.
--
Elias Volanakis | Technical Lead | EclipseSource Portland
elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 |
http://eclipsesource.com--
Elias Volanakis | Technical Lead | EclipseSource Portland
elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 |
http://eclipsesource.com_______________________________________________
riena-dev mailing list
riena-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/riena-dev