Hi Elias,
concerning 2.:
In the predecessor of Riena values with more values after the comma than the precission allows are not shown in the field. It is the responsibility of the applications code to avoid such a situation. How to round is application domain specific and therefore rounding is not handled by the framework.
Since it is considered to be an error in the application code I think instead of not showing the value a much better solution would be to throw an exception.
Another option would be to set a rounding mode on the Ridget like ROUND,FLOOR,CEIL,...?
concerning 3.:
We should definitely support mandatory marking for the DecimalTextRidget. The current behavior in the Markers Demo is wrong. When the value is 0,00 the field is marked yellow indicating that there is no value in a field that requires an input. The yellow marking is removed when the value is changed to 0,01. Instead we must distinguish between a) the valid input 0,0 and b) no input. In the predecessor of Riena this was done by showing only a ',' at a position that indicates the precision:
" , " = no value
" 0,00" = value is 0,0
concerning 4.:
+1 to having re-exports only in the designated bundles
Greetings,
Carsten
Von:
riena-dev-bounces@xxxxxxxxxxx [
mailto:riena-dev-bounces@xxxxxxxxxxx] Im Auftrag von Elias Volanakis
Gesendet: Donnerstag, 23. April 2009 09:16
An: Riena Developers list
Betreff: [riena-dev] Target Milestone reminder / DecimalTextRidget questions / Export question
Hi Rienaers,
a couple of comments and questions:
1. Quick reminder: please remember to set the Target Milestone to '1.1.0.M7' if you resolve bugs in bugzilla. This allows us to create a list of fixed issues for the next new and noteworthy .
Two things about DecimalTextRidget; maybe you can provide some guidance how this was handled in the predecessor of Riena:
2. What should happen when the precision is less than the digits after comma on setText / updateFromModel ?
r.setPrecision(2);
r.updateFromModel(); // 3,1415
results in?
If we allow this into the control, then the next question is how does the text control behave, because we don't allow intermediate illegal values, such as 3,141
3. What should happen when mandatory is 'on' on the DecimalTextRidget? Was that something that was possible in the past? Right now it the Decimal Ridget not support an empty value, so 0 / 0,(0...0) is considered empty. Do we want to allow an empty (',') value?
4. I noticed that some re-exports have sneaked into the following bundles. In my opinion we should limit re-exports to *client* / *server* / org.eclipse.riena.core. See suggestions below.
org.eclipse.riena.monitor.common
15: com.caucho.hessian;bundle-version="3.1.3";visibility:=reexport,
// can be removed without compile rrors
org.eclipse.riena.ui.ridgets.swt
21: org.eclipse.nebula.widgets.compositetable;bundle-version="1.0.0";visibility:=reexport
// should be re-exported by org.eclipse.riena.client and org.eclipse.riena.client.ridgets instead
org.eclipse.riena.ui.swt
8: org.eclipse.equinox.log;bundle-version="1.1.0";visibility:=reexport,
// can be removed without compile errors
Greetings from Portland,
Elias.
--
Elias Volanakis | Technical Lead | EclipseSource Portland
elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 |
http://eclipsesource.com_______________________________________________
riena-dev mailing list
riena-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/riena-dev