[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: AW: [riena-dev] Renaming Interfaces
|
while we normally rename and refactor APIs as we go, I think this such
a fundamental change that we should record the refactoring process all
together and store that recording in org.eclipse.riena.releng. That
way applications already using the Ridgets can easily adapt. I know
there are and will be other API changes that we dont cover in that
way. But in this case we are really changing a lot of classes and
interfaces that people are already dependant on.
So I think its a good idea to record it.
christian
Am 24.10.2008 um 11:35 schrieb Schepp Frank:
+1, but with considering Carstens remarks
-----Ursprüngliche Nachricht-----
Von: riena-dev-bounces@xxxxxxxxxxx [mailto:riena-dev-bounces@xxxxxxxxxxx
] Im Auftrag von Drossel, Carsten
Gesendet: Freitag, 24. Oktober 2008 09:46
An: Riena Developers list
Betreff: AW: [riena-dev] Renaming Interfaces
Hi all!
sound very good, but I have remarks concerning the last two:
IWindowRidget:
We use this not only for the application Shell, but also for inner
"windows" like the working area that holds a SubModuleView.
Therefore I suggest not change this.
IActionRidget:
We use this also for menu items. There is a subclass called
IMenuButton. Maybe IMenuButton should be renamed to
IMenuButtonRidget...? That would be consistent with a superclass
called IButtonRidget.
Greetings,
Carsten
-----Ursprüngliche Nachricht-----
Von: riena-dev-bounces@xxxxxxxxxxx [mailto:riena-dev-
bounces@xxxxxxxxxxx] Im Auftrag von Volanakis, Elias
Gesendet: Freitag, 24. Oktober 2008 06:39
An: Riena Developers list
Betreff: [riena-dev] Renaming Interfaces
Dear colleagues,
I would like to rename several interfaces to align Riena more closely
with SWT/JFace naming conventions. Below is list of proposed changes.
Please let me know if you have any objections.
ITextFieldRidget -> ITextRidget
INumericValueTextFieldRidget -> INumericTextRidget
IDecimalValueTextFieldRidget -> IDecimalTextRidget
IDateTextFieldRidget -> IDateTextRidget
ITreeRidget.collapseTree() -> ITreeRidget.collapseAll()
ITreeRidget.expandTree() -> ITreeRidget.expandAll()
IComboBoxRidget -> IComboRidget
IComboBoxEntryFactory -> IComboEntryFactory
IWindowRidget -> IShellRidget
IActionRidget -> IButtonRidget
Looking forward for your feedback.
Kind regards,
Elias.
_______________________________________________
riena-dev mailing list
riena-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/riena-dev
_______________________________________________
riena-dev mailing list
riena-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/riena-dev
_______________________________________________
riena-dev mailing list
riena-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/riena-dev