Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [recommenders-dev] Snipmatch issues

Hi Stefan,

Thanks for clarifying, now I understand.

I'd say this is OK for now. I think it's best to focus on the other syntax errors before working on further improvements in this area.

Cheers,
Fabian

On 29.10.2013, at 09:03, stefan.prisca@xxxxxxxxx wrote:

Hi Fabian,

Previously, when a class was inserted in the snippet using code proposals, an import section would appear for that class(I guess it’s some basic XText/Xbase behavior).  The problem was, that this import section did not respect the template syntax.
e.g.
  • in the snippet code, trigger code proposals with ctrl-space.
  • select a class from the proposals list
  • when inserting that class, the import section auto-completed for the class, with the syntax 
    import my.class.example.Class instead of ${imp:import(my.class.example.Class)}

This is not done anymore. Now when triggering code completion for a class, it will complete its fully qualified name, and no import section will appear.

e.g.
  • in the snippet code, trigger code proposals with ctrl-space.
  • select a class from the proposals list
  • when inserting that class, the full qualified name for the class will appear:my.class.example.Class,
    without any import section.

This brings up the following question: is this a sufficient work-around for the moment? Inserting a class from the code proposals list will no longer insert a bad import section as well, therefor there are no more syntax errors in the snippets caused by this.


Best Regards,
Stefan.

From: Fabian Steeg
Sent: ‎Tuesday‎, ‎October‎ ‎29‎, ‎2013 ‎12‎:‎48‎ ‎AM
To: Recommenders developer discussions

Hi Stefan, hi Johannes,

Stefan, I reviewed and merged the two changes. In your other message you said that the 'import auto completion' does not work with that change. As I wrote in the comment on Gerrit, with something like `${imp:import(java.lang.String, java.io.File)}`, the change fixed auto completion on the types for me. Is this what you meant?

Johannes, and is this what you meant about import statements not working correctly in your original message?

Cheers,
Fabian

On 28.10.2013, at 13:28, stefan.prisca@xxxxxxxxx wrote:

Hi Johannes,

I pushed 2 changes on gerrit today, one that re-names the grammar[1] and one to fix the import completion[2]. They are not finished yet.

I will try to look into the Tree - New Tree snippet and fix the problem this evening, but I cannot make any promises.
From: Johannes Dorn
Sent: ‎Monday‎, ‎October‎ ‎28‎, ‎2013 ‎2‎:‎22‎ ‎PM
To: Recommenders developer discussions

Hi Stefan, hi Madhuranga,

any progress here? I believe fixing the grammar should be the top priority right now, which mostly affects Stefan.

bye
Johannes

Madhuranga Lakjeewa schrieb:
Hi,
Thank you very much Johannes for pointing out the major issues. I will try to figure out the completion issues you have mentioned.

Thanks,
Madhuranga Lakjeewa 


On Wed, Oct 23, 2013 at 1:27 PM, Johannes Dorn<johannes.dorn@xxxxxxxxxxxxxx> wrote:
Hi,

this goes mainly to Stefan and Madhuranga but there are others who are interested.

We want to show Snipmatch at next week's EclipseCon. There are however some lingering issues with the completion and the editor that we can hopefully fix by then.

Here are some of the things we noticed.
  • Generated snippet Tree - New Tree complains about missing EOF in line2
  • Import statements are not working correctly
  • Sometimes selecting a snippet in the completion, the preview window will show null. This happened for snippet URLConnection 6. I haven't been able to reproduce this reliably.
So the most important issue for now is to fix grammar errors for the editor, so that it doesn't show errors for correct snippets and so that code completion works.
These fixes should include tests.

I will write some tests for the repository indexing logic today.


bye
Johannes

-- 
Johannes Dorn

Codetrails UG (haftungsbeschränkt)
The knowledge transfer company

Robert-Bosch-Str. 7, 64293 DarmstadtTel: +49 6151 2767092
http://www.codetrails.com

Managing Director: Dr. Marcel Bruch
Handelsregister: Darmstadt HRB 91940



_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/recommenders-dev


_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/recommenders-dev

-- 
Johannes Dorn

Codetrails UG (haftungsbeschränkt)
The knowledge transfer company

Robert-Bosch-Str. 7, 64293 DarmstadtTel: +49 6151 2767092
http://www.codetrails.com

Managing Director: Dr. Marcel Bruch
Handelsregister: Darmstadt HRB 91940


_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/recommenders-dev

_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/recommenders-dev


Back to the top