Re: [recommenders-dev] [SnipMatch] New search result display module tria

2012/4/12 Marcel Bruch <bruch@xxxxxxxxxxxxxxxxxx>

Hi,
On 12.04.2012, at 07:35, Chen Cheng wrote:

Hi Marcel,

2012/4/12 Marcel Bruch <marcel.bruch@xxxxxxxxx>

Hi Chen,

You mentioned before, we should prepare a Snipmatch package before Eclipse Juno M2, so what will be focus on after search result display module before M2 ?

IMHO, focus should be:

Doug: check in snipmatch into code recommenders repository
Chen: convert code to the new structure

You mean change project name, re-factor packages etc?
For example, change project name from SnipMatchPlugin -> "org.eclipse.recommenders.snipmatch
Right?

I'm hoping this will be done by Doug? Doug. Maybe it makes sense to commit all the code to gerrit first and work on this patchset until it is in a good shape?

Chen: commit changes against gerrit. If possible create only patches smaller than 200 lines. if this is not possible create one large commit.

I am not very sure why we have to create patches smaller than 200 lines. This is Eclipse's rule? Anyway, i will follow this rule.

all patches below 200 lines don't need an IP check by the Eclipse Legal Team. If it's larger we have a lengthy process to follow. If your initial commit is hard to split into several smaller ones create one large commit to gerrit.

Doug: initiate an IP check for that patch.
All: wait for IP check

In the meanwhile:
Integrate snipmatch into the build and write tests ;)

I will start contribute unit test code soon, but i want to know, is there any *special* rules towards unit-test bundles in Eclipse community?

Hard to say ;) You should have a look at the test bundles in our repository to get an idea.
Marcel

My time is unfortunately very limited until the 18th April. We apply for a large funding and have the final presentation round net week. After that I'll have a close look.

Marcel

On 11.04.2012, at 11:01, Chen Cheng wrote:

Hi all,

SnipMatch's new search result display module is finished, i built it similar with JDT's content assit, you can find the GUI in the attach picture file. You guys can have a trial of it, then i can improve it according to the feedbacks. Or if there are any advises, you can just post it here.

Marcel,
You mentioned before, we should prepare a Snipmatch package before Eclipse Juno M2, so what will be focus on after search result display module before M2 ?

--
Best Regards From Cheng Chen [chengchendoc@xxxxxxxxx]

<search_result_display.png>

_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/recommenders-dev

--
Best Regards From Cheng Chen [chengchendoc@xxxxxxxxx]
_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/recommenders-dev

Thanks,
Marcel

--
Eclipse Code Recommenders:
w www.eclipse.org/recommenders
tw www.twitter.com/marcelbruch
g+ www.gplus.to/marcelbruch

_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/recommenders-dev