Re: [rdf4j-dev] potential iterator leak in repository handling?

[Matthew Nguyen <nguyenm9@xxxxxxx>]

Should they be? If you are querying for triples, how or why do we differentiate whether the returned iterator is AutoCoseable or not?

On Wednesday, April 5, 2023 at 01:48:33 AM EDT, Håvard Ottestad <hmottestad@xxxxxxxxx> wrote:

I don’t think that iterators on models are AutoCloseable. 

Håvard

On 4 Apr 2023, at 22:36, Matthew Nguyen via rdf4j-dev <rdf4j-dev@xxxxxxxxxxx> wrote:



Hey folks,

Think there may be an iterator leak around repository handling.  Statements are pulled and filtered but not seeing how the returned iterator is ever closed.  Relevant code:

https://github.com/eclipse/rdf4j/blob/main/core/repository/api/src/main/java/org/eclipse/rdf4j/repository/config/RepositoryConfig.java#L155 
https://github.com/eclipse/rdf4j/blob/main/core/model/src/main/java/org/eclipse/rdf4j/model/util/Models.java#L97

Can someone more knowledgeable about this code comment?

thx, matt

_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev