Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rap-dev] breaking build change
Current status of the change:


RAP Runtime https://git.eclipse.org/r/25483

The verification job fails as expected. Yes, you can submit changes at any time.
If someone could have a look at the patch and could vote for it, then I would update the verification job configuration this evening and would try to rebase the pending changes in Gerrit.


RAP Tools https://git.eclipse.org/r/25477

There were no uncommitted changes in Gerrit for RAP Tools. Therefore I could change the verification job configuration and it went through successfully. If someone else can give a +2 I'd push the change to the Git repository and make sure that the nightly build job configuration is updated, too.


Thanks,
Markus



On Thu, Apr 24, 2014 at 2:01 PM, Ralf Sternberg <rsternberg@xxxxxxxxxxxxxxxxx> wrote:
Sounds good to me. If I understand correctly, we can continue to
submit changes until we get validation errors from Hudson this
evening, right?

Regards,
Ralf

On Thu, Apr 24, 2014 at 11:44 AM, Markus Knauer
<mknauer@xxxxxxxxxxxxxxxxx> wrote:
> Hi RAP developers,
>
> I'm trying to push a breaking build change as part of this bug:
>
>   Bug 424687: Add common top-level files to git repositories
>   https://bugs.eclipse.org/bugs/show_bug.cgi?id=424687
>
> The 'breaking' part of this change is the move of the pom.xml that drives
> the overall build process from one directory into the root directory of the
> Git repository.
>
> Unfortunately this involves changing all Jenkins job configurations, and it
> may have an impact on other pending changes in Gerrit. At the moment, there
> seem to be 4 open changes in Gerrit for RAP Runtime, one is open for RAP
> Tools.
>
> My proposal is that
>
> - I push this change now (and the build is expected to fail!)
> - I update the Jenkins job configuration this evening and re-run the job for
> this build
> - If this change is 'green' I'll push it to the main Git repository and
> re-run the verification jobs of all other pending changes
>
> Does that sound like a plan, or are there any concerns?
>
> Thanks,
> Markus
>
>
>
> _______________________________________________
> rap-dev mailing list
> rap-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/rap-dev
>
_______________________________________________
rap-dev mailing list
rap-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/rap-dev

Back to the top