Re: [rap-dev] WorkbenchPlugin#getPreferenceManager

[Rüdiger Herrmann <rherrmann@xxxxxxxxxxxxxxxxx>]

Hi Igor,

thank you for your findings. Please create bug entries and attach 
the patches from here.
In order to maintain an IP log [1] we are required to receive 
contributions via patches that are attached to bugzilla entries. 
Plus, bugzilla is a more suitable place to discuss and update patches.

Thanks
Rüdiger

[1] http://www.eclipse.org/projects/dev_process/project-log.php

mail.apptech.nichost.ru wrote:
> Hi
>
> Due to RAP architecture the WorkbenchPlugin#getPreferenceManager works
> incorrect. For example - let some activity to filter out some preference
> page in some cases (it can be necessary if you have to entry points and the
> first one allows users access to some preference pages and the other one -
> denies)
>
> There is a simple solution: move the implementation of
> WorkbenchPlugin#getPreferenceManager to Workbench#getPreferenceManager.
>
> It also will be better to mark WorkbenchPlugin#getPreferenceManager as
> deprecated.
>
> I attached the patch.
>
> Regards,
> Igor
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> rap-dev mailing list
> rap-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/rap-dev