AW: [rap-dev] Cyclical Dependency in Upload Widget and Demo

["Stefan Roeck" <Stefan.Roeck@xxxxxx>]

Hi Elias,

I just want to add one thing to this discussion. Today, I tried to compile the upload widget together with the apache-commons bundles from eclipse orbit using Eclipse release engineering tools (RELENG). I failed. The problem seems to be that the RELENG tools can only handle bundles of two kinds:
a) The bundle is available with source and is compiled by PDE
b) The bundle is already compiled and exists as a JAR file.
Unfortunately, apache.commons.[fileupload|io] *are* compiled but not packaged into a jar. In this case, the classpath in the build.xml of org.eclipse.rwt.upload isn't set-up correctly and the dependencies to the apache.commons-bundles cannot be resolved at compile time.

After spending 3-4 hours with this, I restored the old way in our build environment (commons-lib put into one plugin as jars and exporting all needed packages). However, I didn't undo your changes in the RAP Sandbox.

Just for completeness if anybody runs into a similar problem...
Regards,
Stefan.



-----Ursprüngliche Nachricht-----
Von: rap-dev-bounces@xxxxxxxxxxx [mailto:rap-dev-bounces@xxxxxxxxxxx] Im Auftrag von Volanakis, Elias
Gesendet: Montag, 23. Juni 2008 21:21
An: RAP project development-related communication
Betreff: AW: [rap-dev] Cyclical Dependency in Upload Widget and Demo

Hi Stefan,

thanks for your response: 

	"However, the current two projects have the advantage that someone just has to download them and can test the upload widget without caring about which other bundles are needed (in which versions, etc)"

This is exactly what I don't like about the cyclic dependency, because it *prevents* someone from just downloading the two projects and having something that works (i.e. he has to fix the cyclic dependency first).

I would like to commit a version of those projects without the cyclic dependency. It will include a readme.txt and a project set file that will automatically check out the required apache libraries from eclipse-orbit. This is IMHO easier than fixing the cyclic dependency :).

Let me know what you think.

Kind regards,
Elias.

-----Ursprüngliche Nachricht-----
Von: rap-dev-bounces@xxxxxxxxxxx [mailto:rap-dev-bounces@xxxxxxxxxxx] Im Auftrag von Stefan Roeck
Gesendet: Monday, June 23, 2008 01:18
An: RAP project development-related communication
Betreff: AW: [rap-dev] Cyclical Dependency in Upload Widget and Demo

Hi Elias,

you're right, this cyclic dependency is awful. Your proposal is possible. However, the current two projects have the advantage that someone just has to download them and can test the upload widget without caring about which other bundles are needed (in which versions, etc). Additionally, the demo project will probably never be used in production environment, so it's up to the developer to have a clean dependency graph within its application.

What do you think?
Regards,
Stefan.

-----Ursprüngliche Nachricht-----
Von: rap-dev-bounces@xxxxxxxxxxx [mailto:rap-dev-bounces@xxxxxxxxxxx] Im Auftrag von Volanakis, Elias
Gesendet: Donnerstag, 19. Juni 2008 21:16
An: RAP project development-related communication
Betreff: [rap-dev] Cyclical Dependency in Upload Widget and Demo

Hi,

I've been experimenting with the Upload Widget and Demo in the sandbox.
Thanks for making these available.

However there is a cyclical dependency between the upload widget project
(consuming apache.commons.{fileupload,io}) and the upload widget demo
(providing apache.commons.{fileupload,io}; requiring the upload widget).

I propose to fix this by using the plugins from orbit instead
(org.apache.commons.fileupload v1_2 and org.apache.commons.io v_1_3_2)
and delete the libs from the widget demo project. 

Let know if there is any reason not to do that. I noticed that the io
library provided was v1_4; however the widget seems to work with v1_3_2
as well.

Thanks,
Elias.

PS: I know we are in a ramp down phase, but AFAIK the sandbox is not
part of the release.
_______________________________________________
rap-dev mailing list
rap-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/rap-dev
_______________________________________________
rap-dev mailing list
rap-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/rap-dev
_______________________________________________
rap-dev mailing list
rap-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/rap-dev