Hi Ed
I will use a cgerking/master from now on. The cgerking/bug573449 branch is already rebased on master, though.
The latest changes are rather important to (i) avoid a new plugin dependency and (ii) avoid nearly endless compilations. See the test project attached to https://bugs.eclipse.org/bugs/show_bug.cgi?id=573449.
If it is helpful, I could provide a new branch without the “Simplify search for GenClassifiers” commit, which actually contains code simplifications only.
Kind regards
Christopher
Von: qvto-dev [mailto:qvto-dev-bounces@xxxxxxxxxxx] Im Auftrag von Ed Willink
Gesendet: Mittwoch, 9. Juni 2021 09:13
An: qvto-dev@xxxxxxxxxxx
Betreff: Re: [qvto-dev] 3.10.4RC2
Hi Christopher
For review comments see Bug 573449.
The combination of Bugzilla notification failures and your failure to rebase branches makes it difficult to know what is ready.
For OCL and QVTd, I often maintain an ewillink/master branch to aggregate multiple branches that are ready to be promoted to master. If there was a cgerking/master, I wouldn't need to rebase, sometimes requiring not quite trivial fixups, and you would receive full author+committer credit in the GIT history.
Regards
Ed
On 08/06/2021 15:08, Gerking, Christopher (KASTEL) wrote:
Hi Ed
Thanks a lot!
It seems that one patch for bug 573449 wasn't included (which makes org.eclipse.emf.codegen.ecore optional as discussed).
See https://git.eclipse.org/c/mmt/org.eclipse.qvto.git/commit/?h=cgerking/573449&id=11776f5c4ef5c01d16802a33fb0488f8549c1295.
If still possible, I suggest to include it together with the two minor subsequent improvements on cgerking/573449.
Regards
Christopher
-----Ursprüngliche Nachricht-----
Von: qvto-dev [mailto:qvto-dev-bounces@xxxxxxxxxxx] Im Auftrag von Ed Willink
Gesendet: Dienstag, 8. Juni 2021 11:12
An: QVTOML developer mailing list <qvto-dev@xxxxxxxxxxx>
Betreff: [qvto-dev] 3.10.4RC2
Hi Christopher
3.10.4RC2 is built and contributed including, I hope, the correct latest patches.
The 3.10.4 release will be built and contributed tomorrow evening so please check to see if there is anything that got messed up.
Please delete obsolete development branches / rebase ongoing ones.
Regards
Ed
--
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
_______________________________________________
qvto-dev mailing list
qvto-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/qvto-dev
_______________________________________________
qvto-dev mailing list
qvto-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/qvto-dev
