Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ptp-dev] Process for commmitting PTP fix
Dave,

You'll have to amend the commit, or reset to the previous commit and re-commit, to add the Signed off line. There's a button on the "Commit Changes" dialog to add it. You also need to add a Change-Id using the button next to it.

I'm not sure why it's saying it couldn't connect to the repository. I use https://git.eclipse.org/r/ptp/org.eclipse.ptp for the origin remote and enter the credentials through the Git dialog, so you could try that. I think you already have this configured, so you could just remove the remote you have configured with the ssh URI. Use the Git perspective to manage the repo.

Regards,
Greg

On Feb 19, 2018, at 5:28 PM, David Wootton <dwootton@xxxxxxxxxx> wrote:

Greg
Guess I've been away from this for too long and have forgotten the process.
I committed my changes, but then realized I forgot to add the 'Signed off' line so I don't know how to fix that.

Something is also wrong with my ssh setup since I get the following when I try to push to Gerrit (Team->Remote->Push to Gerrit)
<18826309.gif>

I went to https://git.eclipse.org/r/#/settings/ssh-keys where I can upload ssh public keys and added what is supposed to be my ssh public key, which I got by opening the Key management tab in Preferences->General->Network Connections->SSH2, clicking Load Existing Key and picking the id_rsa file in that directory, then pasting the resulting public key into the git.eclipse.org page. I can see the key show up in the list at the top of the page but that still resulted in the same error when I tried the push again.

Either I have done something wrong or I need to wait more than a minute or two for updates to take effect.

Dave

<graycol.gif>Greg Watson ---02/19/2018 04:22:24 PM---Hi Dave, It looks like you already have it set up to use Gerrit. Have you tried committing your chan

From: Greg Watson <g.watson@xxxxxxxxxxxx>
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 02/19/2018 04:22 PM
Subject: Re: [ptp-dev] Process for commmitting PTP fix
Sent by: ptp-dev-bounces@xxxxxxxxxxx




Hi Dave,

It looks like you already have it set up to use Gerrit. Have you tried committing your changes then pushing to remote (or push to Gerrit?)

Greg

_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_ptp-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=yA1Giwd7Ls577uUKQ3fQWICGHopYggQ46OvlB30WK5M&m=G1T6JeX3hDbDk7op2LhlXUFZu82E-ikOmpVxGJc0cKc&s=uYLbN-9o7WqM0-KIk6Ns3_PiUP8Z24PCIyCXRbNLJbI&e=


_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ptp-dev

Back to the top