| Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion |
Greg
I found out that I had somehow imported code from two different repos for org.eclipse.remote. I deleted all the org.eclipse.remote.* plugins and re-imported them from the master branch and resolved those problems.
I did discover several new problems:
1) The machine I am running on has OpenJDK version 1.8.0_102 installed, and Java -version reports
-bash-4.2$ java -version
openjdk version "1.8.0_102"
OpenJDK Runtime Environment (build 1.8.0_102-b14)
OpenJDK 64-Bit Server VM (build 25.102-b14, mixed mode)
The result is that bootstrap.sh fails with message fail:invalid java version $major.$minor; must be >= 1.8
I modified bootstrap.sh as follows
do_check() {
java_vers=`java -version 2>&1`
major=`expr "$java_vers" : "openjdk version \"\([0-9]*\)\.[0-9]*.*\""`
minor=`expr "$java_vers" : "openjdk version \"[0-9]*\.\([0-9]*\).*\""`
if test "$major" -ge 2 -o "$minor" -ge 8; then
as a quick hack to get around that problem.
2) Then I got a message complaining that plugin org.eclipse.remote.proxy.server.linux.ppc64le could not be found, since my remote node is Power 64 bit little endian. I cloned org.eclipse.remote.proxy.server.linux.x86_64 and changed all the x86_64 strings in all the files in that plugin to ppc64le.
3) Then I got messages
!ENTRY org.eclipse.ptp.launch 4 4 2018-02-13 13:56:40.085
!MESSAGE Unable to start server: null
The only place I can find that message is line 271 of ProxyConnectionBootstrap.java.
That's apparently due to the bootstrap.sh sending back the string ok:not_found/linux/ppc64le
Then there's some state machine logic near line 139 of ProxyConnectionBootstrap trnsitioning to either Sttes.START or States.DOWNLOAD depending on the value of the first token. Since it's not_found the state goes to States.DOWNLOAD and that causes a failure.
not_found is set at line 55 of bootstrap.sh then the code following fails to find org.eclipse.remote.proxy.server.core_$1.jar where I guess $1 is ppc64le.
I'm not sure where this jar file comes from. It's not anywhere on my remote system, including .eclipsesettings and I can't find where it comes from in the workspace. I'm guessing I could clone and rename the x86_64 jar but I can't find any files with x86_64 in their name anywhere in org.eclipse.remote.* either
Dave
Greg Watson ---02/13/2018 09:59:42 AM---Hi Dave, Have you pulled all the latest changes into your org.eclipse.remote repository?
From: Greg Watson <g.watson@xxxxxxxxxxxx>
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 02/13/2018 09:59 AM
Subject: Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion
Sent by: ptp-dev-bounces@xxxxxxxxxxx
Greg
I switched PTP to the ptp_9_1 branch and imported what I think is the proxy plugins, from https://drwootton@xxxxxxxxxxxxxxx/r/p/ptp/org.eclipse.remote.git
I get the following errors when building
<1D549623.gif>I tried clicking 'Quick fix' to see if it could find the required imports wit no luck. They are not in org.eclipse.remote.core. I tried replacing org.eclipse.remote.core in my workspace with what's in the remote master branch, thinking it didn't get refreshed when I tried to import git projects, picking the remote origin/master branch and also with the remote origin/proxy branch with no luck. Do I need to delete all the org.eclipse.remote plugins and re-import, and if so, from what git branch.
This is what I currently have in org.eclipse.remote.core at the HEAD level.
<1D105929.gif>
Dave
<graycol.gif>Greg Watson ---02/12/2018 04:36:03 PM---Hi Dave, You'll need to be on the ptp_9_1 branch for PTP and master branch for o.e.remote. You proba
From: Greg Watson <g.watson@xxxxxxxxxxxx>
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 02/12/2018 04:36 PM
Subject: Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion
Sent by: ptp-dev-bounces@xxxxxxxxxxx
Greg
The only options I have in that dropdown are SSH, Telnet and Serial Port. I'm not sure what I am missing. I issued a pull for both org.eclipse.ptp on the PTP master branch and the org.eclipse.remote PTP-REMOTE branch so I think I have up to date code. I also cleared the workspace for my runtime instance to make sure I didn't have someting in my workspace causing problems.
I also used Eclipse FILE search to look for the string PROXY in org.eclipse.remote source, and didn't find any string, even ignoring case taht looked like it could be used as a widget text element.
Dave
<graycol.gif>Greg Watson ---02/12/2018 11:40:28 AM---Hi Dave, What you're describing is a two-hop ssh connection. To use a proxy, you first need to click
From: Greg Watson <g.watson@xxxxxxxxxxxx>
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 02/12/2018 11:40 AM
Subject: Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion
Sent by: ptp-dev-bounces@xxxxxxxxxxx
Greg
I always got a response from bqueues when I ran it as a ssh command, either a queue list of a timeout message.
I tried to create a proxy connection, but I'm not sure I know how to do that. I specified a ost and username as for a regular ssh connection, then in the advanced settings I clicked the 'remote' button under SSH proxy settings and picked an existing ssh connection. However, I'm thinking I'm still using the original ssh session in this case. I did get the same problem with no notification of command completion once with this connection though.
Dave
<graycol.gif>Greg Watson ---02/09/2018 09:12:14 AM---Hi Dave, I'm not sure what else to suggest. Have you tried submitting the script multiple times with
From: Greg Watson <g.watson@xxxxxxxxxxxx>
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 02/09/2018 09:12 AM
Subject: Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion
Sent by: ptp-dev-bounces@xxxxxxxxxxx
Greg
Any other ideas about what's not working when the bqueues command hangs? I thought there might be something going on if the bqueues command was killed by 'kill -9', but when I tried that I still got notification back to my Eclipse code most times. It did fail once where there was no notification whatsoever.
I'm not surprised, since even in the 'kill -9' case, wherever invoked bqueues should get a return code back, in that case indicating bqueues was terminated.
At this point, I'm thinking I commit what changes I have since they do improve the LSF target system configuration behavior. Previously, the bqueues command would consistently block due to the command and the stdio/stderr stream readers all running on the same thread , and now it's only when the bqueues command fails to return status.
Also, any possibility of getting a rebuild of PTP once my changes are merged in? We need this to ship with our plugins since we depend on LSF target system configurations.
Thanks
Dave
----- Forwarded by David Wootton/Poughkeepsie/Contr/IBM on 02/08/2018 02:50 PM -----
From: David Wootton/Poughkeepsie/Contr/IBM
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 02/05/2018 09:49 AM
Subject: Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion
Greg
I added a sleep just before the exit in the script and that makes no difference. I didn't expect any difference since this execution path should be all non-asynchrouous code. I expect sshd is issuing a fork, exec, and wait to invoke the hack script and then bash does the same when invoking the bqueues command.
The only inconsistent behavior I'm seeing is that sometimes the bqueues command itself times out because LSF daemons apparently aren't responding. But that's all internal to the bqueues command and I do get completion status reported all the way back to my Eclipse code where the return status says the bqueues command exited with rc=255.
I realize the bqueues command could be exiting with some off return code so added an echo statement to my hack script to write the return code to a file on the remote system and the return code was always zero.
Dave
<graycol.gif>Greg Watson ---01/29/2018 03:53:08 PM---Maybe it's a timing issue. What happens if you add 'sleep 5' to the end of the script? Greg
From: Greg Watson <g.watson@xxxxxxxxxxxx>
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 01/29/2018 03:53 PM
Subject: Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion
Sent by: ptp-dev-bounces@xxxxxxxxxxx
Greg
I have a console session open on the login node where the bqueues command runs. Once I click the List button in the run configuration dialog, I periodically issue a 'ps -u dwootton' command to see what processes are running for me on the login node. I see the bqueues command and my hack script running for a while, which is what I expect. But then I ussue the ps command again and see that both the bqueues command and the hack script have terminated, but no output from stdout or stderr is displayed to my Eclipse console view. When the bqueues command works correctly, I see stdout or stderr, sometimes both, getting text back from the remote command. That's why I'm thinking something is losing track of the command invocation since I should see at least the messages from my hack script, which are issued unconditionally before and after the bqueues command runs.
Dave
<graycol.gif>Greg Watson ---01/29/2018 12:17:24 PM---Dave, What do you mean "when the bqueues command disappears"?
From: Greg Watson <g.watson@xxxxxxxxxxxx>
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 01/29/2018 12:17 PM
Subject: Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion
Sent by: ptp-dev-bounces@xxxxxxxxxxx
Greg
That doesn't work. The result is that the name of the remote command is the complete string 'bqueues -l; echo EOF:$?'
I thought I could make this work by running a wrapper script, for instance /home/dwootton/hack on the remote node, where the script is
#!/bin/sh
echo "Execute: " $*
$*
echo "EOF:$?"
And then changing the invocation command in my Eclipse code to 'private static final String bqueuesCommand[] = {"/home/dwootton/hack", "bqueues", "-l"};'
The idea is that the hack script just executes exactly what it is passed.
This works correctly most of the time. However, when the bqueues command disappears, I still get absolutely no output to stdout, not even the text from my hack script.
It looks like something is just completely losing track of the remote command request.in this case.
Dave
<graycol.gif>Greg Watson ---01/26/2018 11:39:03 AM---What happens if you try a single quoted argument, e.g 'bqueues -l; echo EOF:$?' Greg
From: Greg Watson <g.watson@xxxxxxxxxxxx>
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 01/26/2018 11:39 AM
Subject: Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion
Sent by: ptp-dev-bounces@xxxxxxxxxxx
Greg
I tried adding an echo command to the bqueues command and I am not having any success. My original bqueues command that I was passing to the IRemoteProcessBuilder was a String array {"bqueues", "-l"}.
I changed that to {"bqueues", "-l", ";", "echo", "\"EOF:$?\""} and that failed with a LSF error message that there was no such queue as ";", where the semicolon is being passed as a command parameter to the bqueues command instead of as a command separator for bash.
I tried changing ';' tp "\\;" to escape the semicolon and it was still passed as a bqueues command parameter, this time '\;'.
I was able to get the pid of the bash process started to run the bqueues command one time with my original bqueues command hanging and it looks like the command being passed across is actually /bin/bash -l -c cd /autofs/home/dwootton && bqueues -l where "cd /autofs/home/dwootton && bqueues -l" is probably a string parameter to the bash -c option (which tells bash to use the string as the bash command")
So I'm not sure how I can get this hack to work. I think I have a way to deal with the return status in my Java code, but I'm stuck at getting a working command to pass across to the remote system.
Dave
<graycol.gif>Greg Watson ---01/24/2018 12:10:09 PM---Dave, Is there anything still running on the remote end? e.g. is there a shell process? You could tr
From: Greg Watson <g.watson@xxxxxxxxxxxx>
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 01/24/2018 12:10 PM
Subject: Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion
Sent by: ptp-dev-bounces@xxxxxxxxxxx
Greg
I suspended each thread in the Eclipse debugger once I had a hung run configuration dialog
Both my reader threads are waiting
<17443150.gif>
I expected these threads had exited at this point since the remote process was gone and the associated write-side file descriptors should have been closed, causing the pending read to end, at least on Linux. I'm running Eclipse on windows, so maybe file descriptor behavior there is different.
The thread that looks like it might be a connection thread seems to be looping in PipedImputStream.awaitSpace, since I can single step thru it. There is a wait there, with a 1 second timeout.
<17931618.gif>
The Session class is com.jcraft.jsch.Session
I suspended a few other threads and did not see anything that looked like Jsch. I avoided classes that had labels/names that looked like internal Eclipse threads or other unrelated plugins.
Dave
<graycol.gif>Greg Watson ---01/23/2018 10:57:10 PM---Hi Dave, Off the top of my head I don't know, but Jsch is a nasty piece of work. Can you see if it's
From: Greg Watson <g.watson@xxxxxxxxxxxx>
To: Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
Date: 01/23/2018 10:57 PM
Subject: Re: [ptp-dev] IRemoteProcess.isCompleted occaisionally fails to report process completion
Sent by: ptp-dev-bounces@xxxxxxxxxxx
I'm fixing the hangs using the LSF target configuration and have it mostly fixed. One problem I'm running into is that occasionally, the remote process (bqueues -w) exits but the IRemoteProcess.isCompleted() method still returns false, and as a result, my code loops forever waiting for process completion and the run configuation dialog is locked. I can clear the locked state by clicking the red cancel button at the bottom of the dialog.
The loop I have to wait for process completion is
for (;;) {
if (process.isCompleted()) {
break;
}
if (monitor.isCanceled()) {
process.destroy();
return new Status(IStatus.CANCEL, Activator.PLUGIN_ID, CANCELED, Messages.CommandCancelMessage, null);
}
try {
Thread.sleep(1000);
} catch (InterruptedException e) {
// Do nothing, sleep just ends early
}
}
I see comments in the IRemoteProcess source that warn that isCompleted() and waitFor() may not work correctly if the calling thread does not read the stderr or stdout streams and the JSch process implementation is used (which appears to be my case since I see that the process builder os a JSchProcessBuilder) . However, in my case I have reads pending on both the stderr and stdout streams for at least one byte, but I am issuing those reads on a different threads from where the remote process was created. (I'm reading on separate threads to avoid my code blocking if the remote process writes so much data to either stream that the stream buffers fill and the process blocks until something reads from these streams to empty the buffer , and that fixes most of the hangs)
I'm not sure what's going on here to cause the hang. I'm wondering if my InputStream objects need a synchronized attribute because it's being used on a different thread, but that also makes no sense since my InputStream veriable is not visible to anythig other than my code reading the stream.
Any thoughts or suggestions about what might be going on?
Thanks
Dave
}
}
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ptp-dev