[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [ptp-dev] Fix for bug 429083 waiting for review
|
I think right now it is up to the committer to decide if code review is
necessary. For really small or cosmetic changes, pushing to Gerrit is
more formality and you can just review/approve your own change. What
I've been doing is if I think a change should be reviewed by someone and
I know they have knowledge of that part of the code, I've added them as
reviewer(s), e.g. Greg for JAXB stuff, Wyatt for ETFw, etc. Adding
reviewers can't hurt, I don't think Gerrit has any rules that all
reviewers must approve so if nobody responds for a few days, you can
always approve your own change.
Chris
On 03/12/2014 05:44 PM, David Wootton wrote:
I pushed a fix for bug 429083 in Kepler to Gerrit a couple weeks ago
and no one has reviewed it. Is it my responsibility when I push a fix
to designate a reviewer? Do I need to do something else to get this
fix thru the process?
Dave
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev
