Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ptp-dev] APIs

Yes. Open the MANIFEST.MF and go to the Runtime tab. Make sure every package is listed in the Exported Packages table. If not, add them. Select each package in turn and set the Package Visibility to "hidden from all plug-ins except:". Leaving the corresponding table empty will just mark the package internal. You can also export the package to specific plugins so they don't get the "Discouraged access" warnings.

Also, for package names, internal packages should be named org.eclipse.ptp.internal.<component>. There are still quite a few that have the "internal" part in the wrong place. 

When renaming a package there are a couple of gotchas to be aware of. If your plugin is called org.eclipse.ptp.foo and you have a package called org.eclipse.ptp.foo then depending on which options you pick, the refactoring may try to rename the plugin name in the .project and pom.xml files. Make sure you don't do this. Also, there may be fully qualified names in the files that you do or do not want to change. For example, you don't want to change the PLUGIN_ID in the activator or IDs in the plugin.xml. However you do want to change the BUNDLE_ID in Messages.java. Unfortunately this means you need to do a fair bit of manual inspection before accepting the changes.

Thanks,
Greg


On May 3, 2013, at 7:41 PM, Wyatt Spear <wspear@xxxxxxxxxxxxxx> wrote:

Aside from adding internal to the package name is there a procedure for marking a package internal? My googling hasn't turned anything up.
Thanks,
Wyatt


On Fri, May 3, 2013 at 11:28 AM, Beth Tibbitts <tibbitts@xxxxxxxxxx> wrote:

Add my name to all
org.eclipse.ptp.etfw.feedback.*
org.eclipse.ptp.pldt.*


...Beth

Beth Tibbitts
Eclipse Parallel Tools Platform  http://eclipse.org/ptp
IBM STG - High Performance Computing Tools
Mailing Address:  IBM Corp., 745 West New Circle Road, Lexington, KY 40511


<graycol.gif>Greg Watson ---05/03/2013 02:16:53 PM---The following is a list of all the packages currently declaring APIs in PTP. Please review and deter

<ecblank.gif>
    From:
<ecblank.gif>
Greg Watson <g.watson@xxxxxxxxxxxx>
<ecblank.gif>
    To:
<ecblank.gif>
Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
<ecblank.gif>
    Date:
<ecblank.gif>
05/03/2013 02:16 PM
<ecblank.gif>
    Subject:
<ecblank.gif>
[ptp-dev] APIs
<ecblank.gif>
    Sent by:
<ecblank.gif>
ptp-dev-bounces@xxxxxxxxxxx




The following is a list of all the packages currently declaring APIs in PTP. Please review and determine if you are willing to update the javadoc, extension point docs, and as Chris suggest, correctly format the code in these packages. I have made some suggestions for some of these packages, please let me know if you agree and I'll make the changes. I've put my name against the packages I'll be updating. Any unclaimed packages will be marked internal for the release.

Ideally, any changes need to be made by M7 which is Wed May 8.

Thanks,
Greg

org.eclipse.ptp.core - greg

org.eclipse.ptp.debug.core - greg
org.eclipse.ptp.debug.core.event - greg
org.eclipse.ptp.debug.core.launch - greg
org.eclipse.ptp.debug.core.model - greg
org.eclipse.ptp.debug.core.pdi - greg
org.eclipse.ptp.debug.core.pdi.event - greg
org.eclipse.ptp.debug.core.pdi.manager - greg
org.eclipse.ptp.debug.core.pdi.model - greg
org.eclipse.ptp.debug.core.pdi.model.aif - greg
org.eclipse.ptp.debug.core.pdi.request - greg

org.eclipse.ptp.ems.core
org.eclipse.ptp.ems.ui

org.eclipse.ptp.etfw
org.eclipse.ptp.etfw.ui
org.eclipse.ptp.etfw.feedback
org.eclipse.ptp.etfw.feedback.actions.handlers
org.eclipse.ptp.etfw.feedback.views
org.eclipse.ptp.etfw.toolopts

org.eclipse.ptp.etfw.tau.papiselect -> rename & mark internal
org.eclipse.ptp.etfw.tau.papiselect.papic -> rename & mark internal
org.eclipse.ptp.etfw.tau.perfdmf -> rename & mark internal
org.eclipse.ptp.etfw.tau.perfdmf.views -> rename & mark internal
org.eclipse.ptp.etfw.tau.selinst -> rename & mark internal
org.eclipse.ptp.etfw.tau.selinst.popup.action -> rename & mark internals
org.eclipse.ptp.etfw.tau.ui -> rename & mark internal
org.eclipse.ptp.etfw.tau.ui.model -> rename & mark internal

org.eclipse.ptp.pldt.common
org.eclipse.ptp.pldt.common.actions
org.eclipse.ptp.pldt.common.analysis
org.eclipse.ptp.pldt.common.editorHelp
org.eclipse.ptp.pldt.common.util
org.eclipse.ptp.pldt.common.views

org.eclipse.ptp.internal.rdt.core.formatter -> mark internal
org.eclipse.ptp.internal.rdt.make.core.scannerconfig.offline -> mark internal
org.eclipse.ptp.rdt.core
org.eclipse.ptp.rdt.core.activator -> rename & mark internal
org.eclipse.ptp.rdt.core.messages -> rename & mark internal
org.eclipse.ptp.rdt.core.miners
org.eclipse.ptp.rdt.core.remotemake -> rename & mark internal
org.eclipse.ptp.rdt.core.resources
org.eclipse.ptp.rdt.core.serviceproviders
org.eclipse.ptp.rdt.core.services

org.eclipse.ptp.rdt.editor
org.eclipse.ptp.rdt.editor.info

org.eclipse.ptp.rdt.make.internal.ui.editor  -> rename & mark internal
org.eclipse.ptp.rdt.make.ui

org.eclipse.ptp.rdt.managedbuilder.gnu.ui.preferences -> rename & mark internal
org.eclipse.ptp.rdt.managedbuilder.gnu.ui.scannerdiscovery -> rename & mark internal
org.eclipse.ptp.rdt.managedbuilder.gnu.ui -> rename & mark internal

org.eclipse.ptp.internal.rdt.managedbuilder.xlc.ui.scannerdiscovery
org.eclipse.ptp.rdt.managedbuilder.xlc.ui -> rename & mark internal
org.eclipse.ptp.rdt.managedbuilder.xlc.ui.messages -> rename & mark internal
org.eclipse.ptp.rdt.managedbuilder.xlc.ui.environment -> rename & mark internal
org.eclipse.ptp.rdt.managedbuilder.xlc.ui.properties -> rename & mark internal
org.eclipse.ptp.rdt.managedbuilder.xlc.ui.scannerdiscovery -> rename & mark internal

org.eclipse.ptp.rdt.sync.core - greg
org.eclipse.ptp.rdt.sync.core.exceptions - greg
org.eclipse.ptp.rdt.sync.core.handlers - greg
org.eclipse.ptp.rdt.sync.core.listeners - greg
org.eclipse.ptp.rdt.sync.core.resources - greg
org.eclipse.ptp.rdt.sync.core.services - greg

org.eclipse.ptp.rdt.ui -> rename & mark internal
org.eclipse.ptp.rdt.ui.messages -> rename & mark internal
org.eclipse.ptp.rdt.ui.perspectives -> rename & mark internal
org.eclipse.ptp.rdt.ui.preferences -> rename & mark internal
org.eclipse.ptp.rdt.ui.properties -> rename & mark internal
org.eclipse.ptp.rdt.ui.serviceproviders -> rename & mark internal
org.eclipse.ptp.rdt.ui.subsystems -> rename & mark internal
org.eclipse.ptp.rdt.ui.wizards -> rename & mark internal

org.eclipse.ptp.remote.core - greg
org.eclipse.ptp.remote.core.exception - greg

org.eclipse.ptp.remote.server.core - greg

org.eclipse.ptp.remote.ui - greg
org.eclipse.ptp.remote.ui.dialogs - greg
org.eclipse.ptp.remote.ui.widgets - greg

org.eclipse.ptp.rm.jaxb.control.core - greg
org.eclipse.ptp.rm.jaxb.control.ui - greg
org.eclipse.ptp.rm.jaxb.core - greg
org.eclipse.ptp.rm.jaxb.core.data - greg

org.eclipse.ptp.services.core
org.eclipse.ptp.services.ui
org.eclipse.ptp.services.ui.dialogs
org.eclipse.ptp.services.ui.widgets
org.eclipse.ptp.services.ui.wizards


_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev





_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev


_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev


Back to the top