Re: [ptp-dev] Proposed changes to RM monitors

["Alameda, Jay" <alameda@xxxxxxxxxxxx>]

This seems like a step in the right direction, Greg -
Jay

-----Original Message-----
From: ptp-dev-bounces@xxxxxxxxxxx [mailto:ptp-dev-bounces@xxxxxxxxxxx] On Behalf Of Greg Watson
Sent: Friday, October 26, 2012 10:35 AM
To: Parallel Tools Platform general developers
Subject: [ptp-dev] Proposed changes to RM monitors

Currently monitor types are registered using the org.eclipse.ptp.lml.monitor.ui.monitors extension point. The type of the monitor must correspond to the name used by the DA driver perl scripts, and this type must also be used in the "schedulerType" attribute of the <monitor-data> element in the target configuration files. Further, the Monitors view displays the type, and the user must select this type when they are adding a new monitor to the view.

The problems with the current approach are:

1. There is no obvious relationship between the target system configuration that the user used to launch a job and the monitor type, so this is confusing for the user.
2. The only way to add a new monitor type is to add an extension to a plugin, so this can only be done by new PTP releases.
3. Since monitors are not related directly to target system configurations, there is no way to enable control operations (e.g. terminating a job) for manually configured monitors. This means that the stand-along monitors app can't be used for control operations.

This proposal is to:

1. Use target system configurations for both launching and monitoring. When manually adding a monitor, the dialog will only list the target system configurations that contain <monitor-data> elements. The user then selects the target system configuration, and the "schedulerType" attribute is used to notify the DA driver of the expected system type. 
2. The Monitor view will display the target system configuration rather than the monitor type.
3. New monitor types can be added by just using the new string in a "schedulerType" attribute.

Practically, this will involve:

1. Removing the monitors extension point.
2. Modifying the Monitors view and Add Monitor dialog to use target system configurations.
3. Moving the control handlers from the org.eclipse.ptp.rm.jaxb_lml plugin to org.eclipse.ptp.rm.monitors.ui and removing the jaxb_lml plugin.
4. Adding dependencies on the jaxb plugins to the monitors.core and monitors.ui plugins.

Ultimately the goal is to use the target system configuration files (JAXB) to also configure dynamic properties of monitors. This proposal moves closer to this goal.

I have a prototype working and will commit it provided there are no objections to the above.

Regards,
Greg
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev