Re: [ptp-dev] Problem with IRuntimeRemoveNodeEvent

[Dave Wootton <dwootton@xxxxxxxxxx>]

Greg
I just downloaded the code and ran a test with my two node test several 
times and ran, submitting the same job twice so I had two jobs running. In 
all cases the machines pane now deletes the node objects when there are no 
more tasks running on the node (and I've sent a delete node event). So the 
change looks good now.

The one observation, since I'm not sure this is a bug or is your intent, 
is that if I've clicked on a node to see its node attributes and process 
info, then when a node is removed from the machines pane, the text in the 
node attributes and process info remains, with the last status prior to 
the node deleted. So in my case, I see the last process on the node still 
in a running state in the process info pane.

Would it be reasonable to clear the node attributes and process info panes 
if the node whose info they are showing gets deleted?

This isn't a major problem for me, and I'll go along with whatever anyone 
else thinks. Just wanted to be sure you were aware of this behavior.
Dave



Greg Watson <g.watson@xxxxxxxxxxxx> 
Sent by: ptp-dev-bounces@xxxxxxxxxxx
06/08/2007 12:08 PM
Please respond to
Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>


To
Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
cc

Subject
Re: [ptp-dev] Problem with IRuntimeRemoveNodeEvent






Dave,

I've hooked up this event in the machines view now. Please test.

Greg

On Jun 7, 2007, at 2:51 PM, Greg Watson wrote:

>
> On Jun 7, 2007, at 12:45 PM, Dave Wootton wrote:
>
>> I'm having problems with getting a PROXY_EV_RT_REMOVE_NODE event 
>> sent from
>> my proxy to delete the node object from the machine view. My proxy 
>> code
>> calls proxy_remove_node_event to create the event object that I 
>> sent to
>> the front end. This generates a message with two parameters, an 
>> integer
>> '1', and the second parameter, which is a single node identifier, 
>> using
>> the id number generated by my proxy. The front end gets this event 
>> but
>> does not do anything with it.
>>
>> I tried to debug this and found that the
>> handleEvent(IRuntimeRemoveNodeEvent) method at about line 441 in
>> AbstractRuntimeResourceManager is not properly matching the event 
>> id sent
>> from the proxy. I think part of the problem is that the method
>> handleEvent(IProxyRuntimeRemoveNodeEvent) in 
>> AbstractProxyRuntimeSystem
>> near line 509 is using attrs[0] rather than attrs[1]. If I change 
>> this to
>> use attrs[1], then the event is matched and removeNode() is called.
>
> Actually it was the C proxy code that was formatting the event 
> incorrectly. I've updated it now.
>
>>
>> However, the machines view does not seem to be deleting the node 
>> icon.
>> Originally, when my job ended, the node icon changed from a 
>> diamond on
>> green background to caution icon on green background. Now it 
>> changes to
>> caution icon, then to a question mark on white background.
>
> Ah. That would be because I haven't hooked remove events up to the 
> views yet. I wasn't expecting you to start using them so 
> quickly :-). I'll take a look now.
>
>> Dave
>> _______________________________________________
>> ptp-dev mailing list
>> ptp-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/ptp-dev
>
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ptp-dev

_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev