Re: [platform-ui-dev] Async Code Completion Requests in Eclipse Platform

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

> It's already reported at  https://bugs.eclipse.org/bugs/show_bug.cgi?id=348857

It also has a patch attached to it. Maybe someone can help with the
review and manual rebase as Dani is
requesting?https://git.eclipse.org/r/#/c/24199/

I will try to help here, but I'm not sure when I will be able to find
the time for it.

On Mon, Nov 21, 2016 at 7:31 PM, Fabio Zadrozny <fabiofz@xxxxxxxxx> wrote:
> On Mon, Nov 21, 2016 at 4:11 PM, Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:
>>
>> > but the fact that completions auto-apply on space instead of stopping
>> > the completion makes it unusable for this in the current form.
>>
>> Fabio, do you have a bug report for this behavior?
>
> I
> t's already reported at
>  https://bugs.eclipse.org/bugs/show_bug.cgi?id=348857
>
>
>
>
>>
>>
>> Am 21.11.2016 6:03 nachm. schrieb "Fabio Zadrozny" <fabiofz@xxxxxxxxx>:
>>>
>>>
>>>
>>> On Mon, Nov 21, 2016 at 1:29 PM, Mickael Istria <mistria@xxxxxxxxxx>
>>> wrote:
>>>>
>>>> On 11/21/2016 03:58 PM, Lars Vogel wrote:
>>>>
>>>> Hi Mickael,
>>>> .
>>>> Thanks for working on these long outstanding issue.
>>>>
>>>> You're welcome.
>>>> Actually, with the rise of language server and consumption of external
>>>> tools with diverse performances, I guess it's become more critical now that
>>>> it's been before.
>>>> Also, I see other IDEs (IntelliJ, VS, VSCode...) now show completion
>>>> proposals constantly, without trigger characters nor enablement shortcut. I
>>>> tried it, and that's actually a VERY comfortable feature (something that can
>>>> have hundreds of thousands of developers switching). And if Eclipse IDE
>>>> wants to get to continuous completion proposal enabled, async completion is
>>>> very likely to be an important requirement...
>>>
>>>
>>> As a note, this is how PyDev works by default (code completions are
>>> triggered on any char) -- although IMHO, better than async is making
>>> completions fast (for PyDev, there's a timeout which will stop gathering
>>> completions if that timeout is reached -- I think JDT also has that).
>>>
>>> I've done a good amount of work in the latest release to reorder the
>>> completions as the user keeps refining the selection, which I think is
>>> pretty important for async completions (i.e.: the completions on PyDev are
>>> all gotten upon the first activation, after that it's mostly filtering --
>>> with
>>> org.eclipse.jface.text.contentassist.ICompletionProposalExtension2.validate(IDocument,
>>> int, DocumentEvent) -- and resorting based on the changes to the qualifier).
>>>
>>> There are also some quirks on stopping the current completion after a new
>>> '.', but all in all, I think the experience is much better than having to
>>> manually ask for the completion (you just have to keep in mind that for a
>>> new line you always have to use Shift+Enter).
>>>
>>> As a note, I've tried using JDT with a similar mode (mostly making
>>> trigger characters all letters from a-z), but the fact that completions
>>> auto-apply on space instead of stopping the completion makes it unusable for
>>> this in the current form.
>>>
>>> Cheers,
>>>
>>> Fabio
>>>
>>> _______________________________________________
>>> platform-ui-dev mailing list
>>> platform-ui-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>>
>>
>> _______________________________________________
>> platform-ui-dev mailing list
>> platform-ui-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>
>
>
> _______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev



-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com