Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-ui-dev] [eclipse-pmc] Request to backport improvement in default naming scheme of Smart Import

Hi all,

This change was approved by PMC for Neon.1: https://git.eclipse.org/r/#/c/79110/
Can another committer please review it so it can be merged soon?

Thanks in advance,

On 07/26/2016 10:13 AM, Mickael Istria wrote:

Hi all,

In https://bugs.eclipse.org/bugs/show_bug.cgi?id=493716,  there an enhancement about how 2 folders with same names get named as projects inside the IDE when using "File > Open projects for filesystem": rather than having one called myModule and the other called myModule_(1), they'd get called myModule and the other called myComponent_myModule (with myComponent being the name of the parent folder). This patch was pushed into master about a month ago, and this choice of naming was based on discussion with BuildShip maintainers on the platform-ui-dev mailing-list.

As it's improving greatly the user experience for big projects (I usually take wildfly as example which has a lot of folders called "impl" and being maven modules) and the change doesn't add much risk (on the contrary, the change includes a very good test cases to prevent from regressions), I believe it's a good candidate for backport into Neon maintenance branch.

Can PMC please review this request for backport?

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets

Back to the top