Re: [platform-ui-dev] PopupDialog colors change

["Daniel Megert" <daniel_megert@xxxxxxxxxx>]

-1 for the concrete proposed change in
Gerrit. See my comments in Gerrit.

Dani



From:      
 Aleksandar Kurtakov
<akurtako@xxxxxxxxxx>
To:      
 "Eclipse Platform
UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date:      
 15.07.2016 17:43
Subject:    
   [platform-ui-dev]
PopupDialog colors change
Sent by:    
   platform-ui-dev-bounces@xxxxxxxxxxx

---

Hi everyone,

There are many cases where SWT COLOR_INFO_* constants are used in code
ment to receive interaction (selection, input, etc.). It's simply wrong
to use this colors there as they are ment to be use for non-interactive
usecases only thus color mismatches or unreadable content happens quite
often where they are used.
Last such case I face is PopupDialog [1]. There is a patch attached [2]
for you to test. As described in the commit message I went for COLOR_LIST_*
constants to ensure that selections colors don't mismatch with background/foreground.
Please test and give feedback, ideally from all major OSes.

P.S. I would not reply to mails during next week but this should give just
enough time for testing.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=497984
[2] https://git.eclipse.org/r/#/c/77402/

-- 
Alexander Kurtakov
Red Hat Eclipse team
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev