[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [platform-ui-dev] Enhanced extensibility for the default text editor in Eclipse
|
Hi Stefan,
I see you have already commented on the bug.
My proposal is fairly similar to yours.
a) I propose to add a new subclass of TextEditor let's call it
CodeEditor but I would not mark it final but simply add an @noextend
so we are free to modify it but still leave the possibility for
subclasses if one thinks its really needed
b) I would at startup look at all the lexical highlightings available
and register this new CodeEditor for those suffixes/content-types -
we need content-types as well because there are languages eg Bazel
who have no suffix
c) I would implement all this stuff without extension points but pure
Java and DI (where DI strips of all the OSGi-Dependencies) and in a
new bundle / set of bundles
d) I would split the code similar to eclipse.text and jface.text where
we have a UI toolkit neutral part and as a second layer the
presentation of the informations in an SWT UI
e) I would use TextMate as the fall-back grammer and add a simple
grammer language who is closer to the workings of eclipse.text /
jface.text
I see a) & b) as mandatory c), d) e) are not and just how I would do it.
Tom
On 05.07.16 02:07, Stefan Xenos wrote:
> Tom, where did you raise your concerns? I'm trying to catch up with this
> thread.
>
> - Stefan
>
> On Mon, Jun 27, 2016 at 4:43 AM Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx
> <mailto:tom.schindl@xxxxxxxxxxxxxxx>> wrote:
>
> I raised my concerns and won't repeat them any longer. Just for book
> keeping I'm -1 on that change.
>
> Tom
>
> On 27.06.16 13:36, Mickael Istria wrote:
> > On 06/27/2016 01:26 PM, Tom Schindl wrote:
> >> Hi,
> >>
> >> Just to get it right you are modifying TextEditor and not subclassing
> >> and do your smart thing there?
> > For the moment that's our proposal.
> > We did read several comments about concerns of such features "leaking"
> > into specialized editors (JDT, SSE, Xtext) but we tried it anyway
> and it
> > seems that most concerns that were expressed are actually already well
> > handled by the implementation of the specialized editors. So far, our
> > opinion is that it's quite possible to introduce edition features via
> > extension in the default Text Editor without breaking anything,
> and that
> > it's probably even the simplest way to implement it, and the best
> way to
> > allow any editor inside Eclipse to take advantage of it.
> > --
> > Mickael Istria
> > Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
> > My blog <http://mickaelistria.wordpress.com> - My Tweets
> > <http://twitter.com/mickaelistria>
> >
> >
> > _______________________________________________
> > platform-ui-dev mailing list
> > platform-ui-dev@xxxxxxxxxxx <mailto:platform-ui-dev@xxxxxxxxxxx>
> > To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> > https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
> >
>
>
> --
> Thomas Schindl, CTO
> BestSolution.at EDV Systemhaus GmbH
> Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
> http://www.bestsolution.at/
> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
> _______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx <mailto:platform-ui-dev@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>
>
>
> _______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>
--
Thomas Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck