Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-ui-dev] Properties view bug 495567 review

Andrey, 

It looks a complex issue, so it is good to take a look and try to understand it.

IIUC, the root cause is we started allowing Parts to implement OR adapt ISaveablePart.
As a consequence some saveable views, using adapters, are showing a dirty marker.

With the first change, https://git.eclipse.org/r/#/c/75126/, we enforce a part adapting ISaveablePart, to handle and propagate properly the dirty state. But this causes an issue as some views are showing a dirty marker. (i.e. debug view)

With the second change, https://git.eclipse.org/r/#/c/75318/, you introduced an opt-in mechanism, to avoid breaking behavior of existing tools, where:
By default the framework does not show "dirty" markers for view, as default ISecondarySaveableSource#isDirtyStateSupported() is false.
But a developer can opt in by changing the default "false" to "true"

I commented both on the bug, and here so it will be easier to find the reference for people googling this topic.

Kind Regards,

Patrik Suzzi
Software 
Engineer, Eclipse
Platform UI Committer
https://about.me/psuzzi

mobile+39 333 39 79 300  
skypepatrik.suzzi

On Fri, Jun 17, 2016 at 1:52 PM, Andrey Loskutov <loskutov@xxxxxx> wrote:
Hi,

I would like to ask interesting Platform UI committers to review two patches for bug 495567. If nobody answers, I will pick some by myself :-)

TL;DR: as an unexpected side effect of one fix in 4.5 Properties view can get into "dirty" state under some conditions.

The proposed patches for bug 495567 fix the broken "dirty" state transitions for Properties view and give a way how the "dirty" state behavior can be customized.

Details on comment 18: https://bugs.eclipse.org/bugs/show_bug.cgi?id=495567#c18.

Comments on bug 495567 & patches are welcome!

Thanks!

Kind regards,
Andrey Loskutov

http://google.com/+AndreyLoskutov
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev


Back to the top