Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[platform-ui-dev] Fixing Sonar issues for RC1

Friends of Platform UI,

a while ago Mickael (IIRC) configured Sonar for our Git repositories.
The Eclipse Sonar instance can be found here:
https://dev.eclipse.org/sonar/

You can access the identifed issues for the following links:

eclipse.platform.text
https://dev.eclipse.org/sonar/drilldown/issues/33533

eclipse.platform.ui
https://dev.eclipse.org/sonar/drilldown/issues/33359

eclipse.platform.runtime
https://dev.eclipse.org/sonar/drilldown/issues/133284

While not all reported issues are IMHO relevant, you may want to have
a look at issues of the category "Performance". For example we have
several issues of inefficient iterations, for example
https://dev.eclipse.org/sonar/drilldown/issues/33359?&rule=findbugs%3AWMI_WRONG_MAP_ITERATOR&rule_sev=CRITICAL

I think solving such issues for RC1 is desirable. I believe our
Round-up milestone is a good milestone to work on such issues.

I worked on a few for eclipse.platform.runtime and text. Maybe others
want to chip in.

Bug 492963 --- org.eclipse.e4.core.internal.contexts.EclipseContext
makes inefficient use of keySet iterator instead of entrySet iterator
Bug 492969 --- org.eclipse.e4.core.internal.tests.contexts.inject.GenericsListTest$TestNamedObject.combineIt()
concatenates strings using + in a loop
Bug 492970 --- Prefer usage of Long.valueOf() over new Long in
org.eclipse.core.runtime and org.eclipse.e4.core.di
Bug 492971 --- Remove new String() from org.eclipse.e4.core.tests and
org.eclipse.core.tests.runtime
Bug 492973 - Avoid invoking inefficient new String() constructor in eclipse.text

For example the  Performance - Inefficient use of keySet iterator
instead of entrySet iterator in text might be something you may want
to fix for RC1

https://dev.eclipse.org/sonar/drilldown/issues/33533?&rule=findbugs%3AWMI_WRONG_MAP_ITERATOR&rule_sev=CRITICAL

Please note that the Sonar rule set seems to require an update, I
opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=492958 for that.

Best regards, Lars

-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com


Back to the top