Re: [platform-ui-dev] Generify JFace Databinding

[Stefan Xenos <sxenos@xxxxxxxxxx>]

> there are still Gerrit reviews pending with comments that you Stefan marked as "I need to think about the correct solution".

Yes. There are some outstanding code reviews that would add generification to some additional plugins, but no part of the generification work has been committed to those plugins yet... and to be honest, most of those gerrit reviews will probably go in verbatim -- they just need more test coverage and more time spent under review.

The plugins that are finished are commited. The ones that are still in progress are in gerrit... and there are several where the work hasn't started yet. There is no plugin that is partially generified.

> And always adding warning filters is not a solution.

Unless someone created a single commit that were to generify the entirety of the Eclipse platform, there will be plugins where some of its dependencies have been generified and others haven't. Nobody will ever create such a giant commit. In the meantime you need warning filters.

> I haven't looked into the details. What is missing and were do you need support?

Pick a plugin that hasn't been generified yet and start adding the generics. :-) Or pick one that I've already started and help with the code review or with writing tests and examples.

  - Stefan

On Thu, Apr 21, 2016 at 12:32 PM Dirk Fauth <dirk.fauth@xxxxxxxxx> wrote:

Don't get me wrong, I'm always the last that wants to rollback things again. Better is to finish things. AFAIK there are still Gerrit reviews pending with comments that you Stefan marked as "I need to think about the correct solution". I am not aware of the current state, but the way it is right now it will cause a lot of customer complaints regarding the generification of data binding. And always adding warning filters is not a solution.

I haven't looked into the details. What is missing and were do you need support?

Am 21.04.2016 21:16 schrieb "Lars Vogel" <lars.vogel@xxxxxxxxxxx>:

Hi Dirk, cc Stefan

one thing to consider here is that the generification of the existing
plug-ins was a tremendous effort for Stefan and other involved
committers. A rollback will most likely prevent us from finishing the
work in 4.7.

If the works gets done in 4.7, a customer can add the generified
versions to his target platform, even if he used 4.6.

Best regards, Lars

On Thu, Apr 21, 2016 at 5:39 PM, Dirk Fauth <dirk.fauth@xxxxxxxxx> wrote:
> Hi,
>
> Today I checked out my e4 migration tutorial sources with the latest Neon
> integration build. I got lots of warnings related to generics. That's OK
> because of generifying databinding, and so I started to add generics to my
> databinding code.
>
> To make it short, I was not able to get rid of all warnings. It looks like
> the job is only done half the way.
>
> I don't want to blame anybody, but we can not leave it that way. It either
> needs to be finished or reverted for Neon and taken up afterwards again.
>
> Greez,
> Dirk
>
>

> _______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

--
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev