Re: [platform-ui-dev] Anyone mind if I run the code formatter onjface?

["Daniel Megert" <daniel_megert@xxxxxxxxxx>]

> I think for files in which you are planning to make
changes, running
> the formatter upfront is OK, but I also would avoid doing this as
a
> bulk operation.

+1 on that

Dani



From:      
 Lars Vogel <lars.vogel@xxxxxxxxxxx>
To:      
 "Eclipse Platform
UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date:      
 08.12.2015 08:12
Subject:    
   Re: [platform-ui-dev]
Anyone mind if I run the code formatter on        jface?
Sent by:    
   platform-ui-dev-bounces@xxxxxxxxxxx

---

I think for files in which you are planning to make
changes, running
the formatter upfront is OK, but I also would avoid doing this as a
bulk operation.

Best regards, Lars

On Tue, Dec 8, 2015 at 6:51 AM, Andrey Loskutov <loskutov@xxxxxx>
wrote:
> I would prefer you wouldn't run formatter on existing code. I do not
plan any big change, but this would make git blame annotations diff  useless
and this is a major issue.
>
> Am 8. Dezember 2015 05:07:15 MEZ, schrieb Stefan Xenos <sxenos@xxxxxxxxxx>:
>>Most of the files seem to be inconsistently formatted, which causes
>>pain
>>whenever the post-save action runs. IMO, it would make sense to
>>auto-format
>>the lot.
>>
>>The trouble is, a big change like this will create merge problems
if
>>there's any big outstanding patches in the queue. Anyone working
on
>>anything, or should I go ahead?
>>
>>
>>------------------------------------------------------------------------
>>
>>_______________________________________________
>>platform-ui-dev mailing list
>>platform-ui-dev@xxxxxxxxxxx
>>To change your delivery options, retrieve your password, or unsubscribe
>>from this list, visit
>>https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>
> --
> Kind regards,
> Andrey Loskutov
>
> http://google.com/+AndreyLoskutov
> _______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev



-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (032) 221739404, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev