| Re: [platform-ui-dev] Help with Gerrit reviews |
Thanks Dirk, sounds great.
Hi,
my apologies for that. Of course you are right and we should be more active with reviewing.
In my case the reason is the not good enough usage of Gerrit. This means, I rarely look into the "Watched Changes" section and missed to configure the email notifications correctly. Therefore I missed all those contributions, which lead to not reviewing patches for which I wasn't set as reviewer.
For all that are also a victim of missing notifications, maybe the correct settings help.
- Login to Gerrit
- Go to the Settings (click on your name in the upper right corner and select "Settings")
- Got to the "Watched Projects" section
- Add the platform projects (e.g. enter platform/eclipse.platform.ui to the Project Name field and click on "Watch" or search for the projects via "Browse")
- Select the email notifications for the projects, so you get emails when patches for that project are contributed via GerritI'm not sure if you already know that setting. In my case I missed that for the platform projects and now added them.
Regarding the reviews, I will try to do some the next days.
Greez,
Dirk
Am 28.08.2015 17:42 schrieb "Lars Vogel" <lars.vogel@xxxxxxxxxxx>:Hi Jonas,
I think the following query should filter the reviews with -1 or -2.
https://git.eclipse.org/r/#/q/project:platform/eclipse.platform.ui+status:open+-owner:%22Lars+Vogel%22+and+-owner:%22Simon+Scholz%22+and+-owner:%22Sopot+Cela%22+and+-owner:%22Brian+de+Alwis%22+-owner:%22Andrey+Loskutov%22+and+NOT+label:Verified-1+and+NOT+label:Code-Review-1+and+NOT+label:Verified-2
It is the result of entering the following into the search box:
project:platform/eclipse.platform.ui status:open -owner:"Lars Vogel"
and -owner:"Simon Scholz" and -owner:"Sopot Cela" and -owner:"Brian de
Alwis" -owner:"Andrey Loskutov" and NOT label:Verified-1 and NOT
label:Code-Review-1 and NOT label:Verified-2
My result list still shows a few reviews with -2 so if someone see my
error in the query, please send an updated one.
Best regards, Lars
On Fri, Aug 28, 2015 at 5:30 PM, Jonas Helming
<jhelming@xxxxxxxxxxxxxxxxx> wrote:
> Hi Lars,
>
> I checked the list, but for most of the reviews, there are already
> comments and on-going discussions. It is hard to figure out, on which
> reviews it makes sense to help.
> Would it be possible to narrow it down a bit?
>
> Best regards
>
> Jonas
>
> Am 28.08.2015 um 17:08 schrieb Lars Vogel:
>> Dear friends of Platform UI,
>>
>> Currently we have several open Gerrit reviews in our queue. It would
>> be great if you could help to review a few of them.
>>
>> Especially it would be nice if the "new" committers could help here. I
>> have the vague memory that they also complaint about missing feedback
>> on their Gerrit review before they become committer.
>>
>> One query which focus on open community patches:
>>
>> https://git.eclipse.org/r/#/q/project:platform/eclipse.platform.ui+status:open+-owner:%22Lars+Vogel%22+and+-owner:%22Simon+Scholz%22+and+-owner:%22Sopot+Cela%22+and+-owner:%22Brian+de+Alwis%22+-owner:%22Andrey+Loskutov%22
>>
>> Best regards, Lars
>>
>
> --
> Dr. Jonas Helming
>
> Senior Software Architect / General Manager
> EclipseSource Munich
>
> Email: jhelming@xxxxxxxxxxxxxxxxx
> Web: http://eclipsesource.com/munich
> Phone: +49 89 21 555 30 - 11
> Mobile: +49 170 31 51 698
> Fax: +49 89 21 555 30 - 19
> Skype: jonas.helming
>
>
> EclipseSource München GmbH
> Agnes-Pockels-Bogen 1
> 80992 München
>
> General Managers: Dr. Jonas Helming, Dr. Maximilian Kögel
> Registered Office: Agnes-Pockels-Bogen 1, 80992 München,
> Commercial Register München, HRB 191789
>
> _______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
--
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (032) 221739404, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev