| Re: [platform-ui-dev] How to rename a view ID on an namespace-restructuring update ? |
|
Hi all, FYI we ended up implementing Wim’s suggestion with the fake view just closing itself. We’ve added a Capability def to hide the “compatibility view” from the user. It took us a couple attempts to get everything right but in the end things look very clean now.
Thanks for your help and suggestions ! – Code is here if you’re interested: and 2 more older commits. Thanks, Martin -- Martin Oberhuber, SMTS / Product Owner – Development Tools,
Wind River direct +43.662.457915.85 fax +43.662.457915.6 From: platform-ui-dev-bounces@xxxxxxxxxxx [mailto:platform-ui-dev-bounces@xxxxxxxxxxx]
On Behalf Of Wim Jongman Well you can tuck that new view away in some category and accept that. I would not mind as a user. The view description would be something like "Temporary compatibility view" or something.
Your next release would not contain that view. Accepting some temporary side effects from refactoring is something I could live with.
Cheers, Wim On Fri, May 8, 2015 at 8:35 AM, Oberhuber, Martin <Martin.Oberhuber@xxxxxxxxxxxxx> wrote:
Hi Wim,
I like your approach because the “migration code” would _only_ be executed if there is a real need for migration ie the old view ID in a workspace/perspective.
One issue I see is that the old view ID would also appear in Window > Show View > Other … which doesn’t make sense (would look like a duplicated view).
I guess we could hide that with a Capability definition but that doesn’t look very elegant …
Unless somebody has any different idea here ?
Thanks,
Martin
--
Martin Oberhuber, SMTS / Product Owner – Development Tools,
Wind River
direct +43.662.457915.85 fax +43.662.457915.6
From:
platform-ui-dev-bounces@xxxxxxxxxxx [mailto:platform-ui-dev-bounces@xxxxxxxxxxx]
On Behalf Of Wim Jongman
Maybe you can ship a new view with the old Id that opens the old view with the new id and then closes itself? Cheers, Wim
On May 7, 2015, at 00:14, "Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx> wrote:
Hi Platform/UI experts,
As part of the TM Terminal restructuring that we’ve done recently, we’ve changed the ID of a view to the new namespace.
This causes issues when the view was active in a perspective when the update is applied:
See
https://bugs.eclipse.org/bugs/show_bug.cgi?id=466644
Do you see any way we could avoid this ? For instance, provide plugin.xml markup that would specify the view as “no longer existant thus close on restart”.
We thought about a PerspectiveListener, but we’d like to avoid unnecessary plugin activation if possible.
If you have any thought or idea, we’d really appreciate a comment on the bug !
Thanks,
Martin
--
Martin Oberhuber, SMTS / Product Owner – Development Tools,
Wind River
direct
+43.662.457915.85 fax
+43.662.457915.6
|