Re: [platform-ui-dev] platform.ui contributor review days

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

Hi Wim,

If you review and test a Gerrit code change you help the platform.ui committer to merge it easier and faster.

With your review you can for example help the contributors to fix "formal issues" like whitespace, missing copyright, etc. You can also help the contributor to fix code issues, enhance the code or to fix ensure that the test suite runs.  Also with your additional testing you can ensure that the change does not break something else.

Best regards, Lars

On Mon, Feb 2, 2015 at 3:16 PM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:

Hi Lars,

How would this work when I help to review but cannot commit?

Cheers,

Wim

On Feb 2, 2015, at 11:25, Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:

FYI - Wojciech and myself are planning to have contributors reviews days between 05.02 to 09.02.

Would be great if others good also could help. Reviews can be done by anyone, you do not need to be a committer to do a review. So please help us:

https://git.eclipse.org/r/#/q/project:platform/eclipse.platform.ui+status:open

Best regards, Lars

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

--

Geschäftsführer

vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (032) 221739404, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com