Re: [platform-ui-dev] Code Formatter

[<p.bodnar@xxxxxxxxxx>]

https://wiki.eclipse.org/index.php?title=Platform_UI%2FHow_to_Contribute&diff=374387&oldid=366794 :)
______________________________________________________________
> Od: Lars Vogel <lars.vogel@xxxxxxxxxxx>
> Komu: "Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
> Datum: 23.11.2014 16:57
> Předmět: Re: [platform-ui-dev] Code Formatter
>
>Hi,
>
>Feel free to improve the wiki, that is why it is a wiki. :-)
>
>Best regards, Lars
>Am 23.11.2014 10:32 schrieb <p.bodnar@xxxxxxxxxx>:
>
>> Hi Lars,
>>
>> thanks - I see it now: the UI projects are pre-configured to use a project
>> specific formatter settings, AND this is also true for the "Save actions"
>> (with "Format edited lines" set to true). Still, the wiki page could be
>> improved in some ways, but I don't want to bother you with this - if you at
>> the UI projects find that you have to repeatedly explain some rules or
>> settings to new contributors, then you will surely know how to amend the
>> page :)
>>
>> BTW I think it is a bit pity that there are no common shared rules (they
>> could be optional, of course) on how to contribute across ALL the Eclipse
>> projects. At least I haven't found any yet. I mean for example the Webtools
>> project(s) which is handled differently. On the other side, I can imagine
>> managing such an effort could be quite difficult. But I'm getting to quite
>> a different theme here...
>>
>> Regards
>>
>> Petr
>> ______________________________________________________________
>> > Od: Lars Vogel <lars.vogel@xxxxxxxxxxx>
>> > Komu: "Eclipse Platform UI component developers list." <
>> platform-ui-dev@xxxxxxxxxxx>
>> > Datum: 23.11.2014 07:59
>> > Předmět: Re: [platform-ui-dev] Code Formatter
>> >
>> >Hi Petr,
>> >
>> >in platform.ui we set the formatter on the project basis so that
>> >contributors do not have to worry about that. If you find a project
>> without
>> >that, please open a bug and copy me into it.
>> >
>> >Best regards, Lars
>> >
>> >On Sat, Nov 22, 2014 at 3:40 PM, <p.bodnar@xxxxxxxxxx> wrote:
>> >
>> >> Hi everyone,
>> >>
>> >> from my experience, the contributors not always use the Eclipse default
>> >> formatter, or the project-configured one. Or at least at some projects.
>> So,
>> >> to spend some headaches when committing, I find it a good practise to
>> have
>> >> "Save actions -> Format source code -> Format edited lines" activated.
>> >>
>> >> So my question: is there someone responsible willing to update the wiki
>> >> page correspondingly?
>> >>
>> >> Thanks
>> >>
>> >> Petr
>> >> ______________________________________________________________
>> >> > Od: Lars Vogel <lars.vogel@xxxxxxxxxxx>
>> >> > Komu: "Eclipse Platform UI component developers list." <
>> >> platform-ui-dev@xxxxxxxxxxx>
>> >> > Datum: 22.11.2014 14:35
>> >> > Předmět: Re: [platform-ui-dev] Code Formatter
>> >> >
>> >> >Hi Thibault,
>> >> >
>> >> >wie use the Eclipse default formater. In most cases this is already
>> >> >configured in the plugin properties. If not please open a bug and
>> assign
>> >> it
>> >> >to me.
>> >> >
>> >> >Best regards, Laes
>> >> >Am 22.11.2014 13:45 schrieb "Thibault Le OUAY" <
>> thibaultleouay@xxxxxxxxx
>> >> >:
>> >> >
>> >> >> Hey,
>> >> >>
>> >> >> Lately i have started contributing a bit, i have followed the
>> >> instruction
>> >> >> here : https://wiki.eclipse.org/Platform_UI/How_to_Contribute
>> >> >>
>> >> >> All it says  about code formatting :
>> >> >>
>> >> >> - UI will need you to use project-specific settings for compiler
>> >> >> warnings/errors, code formatting etc. that are copied from the other
>> UI
>> >> >> plug-ins' settings.
>> >> >>
>> >> >> - Avoid adding trailing whitespace. You can use the save actions in
>> >> >> Eclipse to auto-remove them, via the Preferences -> Java -> Editor ->
>> >> Save
>> >> >> Actions. Activate them and as additional action select Configure and
>> >> select
>> >> >> "Remove trailing whitespace"
>> >> >>
>> >> >>
>> >> >> I havent found a code formatter template anywhere,
>> >> >>
>> >> >> So is there a specific code formatter for platform.ui ?
>> >> >>
>> >> >>
>> >> >> Best,
>> >> >>
>> >> >> Thibault
>> >> >>
>> >> >> _______________________________________________
>> >> >> platform-ui-dev mailing list
>> >> >> platform-ui-dev@xxxxxxxxxxx
>> >> >> To change your delivery options, retrieve your password, or
>> unsubscribe
>> >> >> from this list, visit
>> >> >> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>> >> >>
>> >> >
>> >> >
>> >> >----------
>> >> >
>> >> >_______________________________________________
>> >> >platform-ui-dev mailing list
>> >> >platform-ui-dev@xxxxxxxxxxx
>> >> >To change your delivery options, retrieve your password, or unsubscribe
>> >> from this list, visit
>> >> >https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>> >> >
>> >> _______________________________________________
>> >> platform-ui-dev mailing list
>> >> platform-ui-dev@xxxxxxxxxxx
>> >> To change your delivery options, retrieve your password, or unsubscribe
>> >> from this list, visit
>> >> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>> >>
>> >
>> >
>> >
>> >--
>> >Geschäftsführer
>> >
>> >vogella GmbH
>> >
>> >Haindaalwisch 17a, 22395 Hamburg
>> >Amtsgericht Hamburg: HRB 127058
>> >Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
>> >USt-IdNr.: DE284122352
>> >Fax (032) 221739404, Email: lars.vogel@xxxxxxxxxxx, Web:
>> >http://www.vogella.com
>> >
>> >
>> >----------
>> >
>> >_______________________________________________
>> >platform-ui-dev mailing list
>> >platform-ui-dev@xxxxxxxxxxx
>> >To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> >https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>> >
>> _______________________________________________
>> platform-ui-dev mailing list
>> platform-ui-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>
>
>----------
>
>_______________________________________________
>platform-ui-dev mailing list
>platform-ui-dev@xxxxxxxxxxx
>To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>