[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [platform-ui-dev] Selection and downport process of bugs
|
> So the fix has passed review, and
I’ve committed it to master. Do I cherry-pick the fix to R4_4_maintenance
and push it up to Gerrit for review again on R4_4_m or can I push it directly?
One review/Gerrit is enough.
> A better flow that I’ve seen for
these types of issues is to commit to R4_4_maintenance and then periodically
merge R4_4_maintenance back into master.
This is actually the wrong workflow.
We must put the fix in 4.5, then wait a week or two and when it doesn't
cause regressions we do the backport.
Dani
From:
Brian de Alwis <briandealwis@xxxxxxxxx>
To:
"Eclipse Platform
UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date:
10.07.2014 15:53
Subject:
Re: [platform-ui-dev]
Selection and downport process of bugs
Sent by:
platform-ui-dev-bounces@xxxxxxxxxxx
So the fix has passed review, and I’ve committed it to
master. Do I cherry-pick the fix to R4_4_maintenance and push it
up to Gerrit for review again on R4_4_m or can I push it directly?
A better flow that I’ve seen for these types of issues
is to commit to R4_4_maintenance and then periodically merge R4_4_maintenance
back into master. It improves traceability as otherwise we what looks
like two different fixes.
Brian.
On 10-Jul-2014, at 4:26 AM, Daniel Megert <daniel_megert@xxxxxxxxxx>
wrote:
We discussed this in one of our recent
Platform UI meetings and decided to try the same process as e.g. JDT: we
reopen the bug (if closed already) and set the target milestone to the
earliest release where the fix is available. In the bug report we provide
the URL for the Git change for each affected branch/release. So, no more
cloning! :-)
HTH
Dani
From: Lars
Vogel <lars.vogel@xxxxxxxxx>
To: "Eclipse
Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date: 10.07.2014
10:20
Subject: Re:
[platform-ui-dev] Selection and downport process of bugs
Sent by: platform-ui-dev-bounces@xxxxxxxxxxx
Thanks Dani, IIRC we used to clone the bug for downports and cherry-picked
(?) the commit from master. Maybe Paul can add more details.
Am 10.07.2014 10:07 schrieb "Daniel Megert" <daniel_megert@xxxxxxxxxx>:
We should apply at least as strict rules as for https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_4.php#FixPassAfterRC0.
Only
Only bugs that we categorize as critical (or as trivial as a typo) should
be chosen for Luna SR1. The fix should go through Gerrit and be reviewed.
Dani
From: Lars
Vogel <lars.vogel@xxxxxxxxx>
To: "Eclipse
Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date: 10.07.2014
08:48
Subject: [platform-ui-dev]
Selection and downport process of bugs
Sent by: platform-ui-dev-bounces@xxxxxxxxxxx
Hi,
I think Brians fix from https://bugs.eclipse.org/bugs/show_bug.cgi?id=438736
is planned to be downported.
Can someone remind me of the process how we select fixes for downports
and the process?
Best regards, Lars_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev