Re: [platform-ui-dev] Community Contribution (patches) days, Nov 6th/7th

[Eric Moffatt <emoffatt@xxxxxxxxxx>]

Hi Curtis, good pickup. I expect that
since one was obviously cloned from the other that we should likely make
the fix in both as well...

Lars, do you agree... ?

Onwards,
Eric

From:	Curtis Windatt/Ottawa/IBM@IBMCA
To:	"Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date:	11/06/2012 03:03 PM
Subject:	Re: [platform-ui-dev] Community Contribution (patches) days,        Nov 6th/7th
Sent by:	platform-ui-dev-bounces@xxxxxxxxxxx

---

FYI, I took a look at 

Bug
385037 - ShowViewDialog - Enable multi-user
environment 

There are two ShowViewDialogs (on in ui.workbench, the other e4.workbench.swt).
The old dialog opens from the main menu. The new e4 dialog opens when opened
from quick access. If only the new dialog should be opened, the patch on
385037 is sufficient, but we have a new issue to deal with. If the inconsistency
is intentional, it's trivial to fix the code in both dialogs.

Does anyone know if this was intentional? Oleg?

Curtis

Eric
Moffatt---11/06/2012 01:52:38 PM---Paul I'll be taking a stab at the following:
Bug 389973 - [Navigator] ProjectExplorer Link with Edit

From: Eric Moffatt/Ottawa/IBM@IBMCA
To: "Eclipse Platform UI component
developers list." <platform-ui-dev@xxxxxxxxxxx>, 
Date: 11/06/2012 01:52 PM
Subject: Re: [platform-ui-dev] Community
Contribution (patches) days, Nov 6th/7th
Sent by: platform-ui-dev-bounces@xxxxxxxxxxx

---

Paul I'll be taking a stab at the following: 

Bug
389973 - [Navigator] ProjectExplorer Link
with Editor only works on the first selection within the editor 
Bug
280825 - Support for multiple window icons
Bug
385346 - Toggeling the visibility of the
toolbar disables the Select All command 
Bug
386870 - [DataBinding] SWTObservables.observeFocus
does not fire change events on FocusOut 
Bug
387367 - JFace Snippet Snippet010OwnerDraw
rework 
Bug
376821 - Request specific framework event
that ends the startup process 
Bug
378535 - "Close All" and "Close
Others" menu options available when right clicking on tab in PartStack
when no part is closeable 
Bug
385037 - ShowViewDialog - Enable multi-user
environment 

I've commented on a few others...mostly to request a snippet / project
to show the issue and to show that the patch fixes it. This is something
we should blog about I think...I'm unwilling to commit a patch in an area
that I'm unfamiliar with just based on the contributor's say so but in
some cases the same unfamiliarity means that manually constructing the
test would take more time that we have... 

Onwards, 
Eric

From:	Paul Webster <pwebster@xxxxxxxxxxxxxxxxxxx>
To:	E4 Project developer mailing list <e4-dev@xxxxxxxxxxx>, "Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date:	11/06/2012 09:36 AM
Subject:	Re: [platform-ui-dev] Community Contribution (patches) days, Nov 6th/7th
Sent by:	platform-ui-dev-bounces@xxxxxxxxxxx

---

The set of bugs I'll review and comment on:

Bug
377884 - @CanExecute is not executed using
DirectItems
Bug
2369 - [Workbench] Would like to be able
to save workspace without exiting
Bug
357786 - [KeyBindings] Delete Key is not
working in editor
Bug
378495 - Part Toolbar does not refresh when
toolbar items are removed
Bug
374568 - Part menu is not rendered correctly
after removing menu items
Bug
383497 - "Build Project" key binding
no longer works in 4.2 / juno
Bug
389624 - [E4AP] NPE during loading of workbench.xmi
Bug
389663 - [E4AP] Merging contributions can
lead to duplicate elements in the model
Bug
384560 - Print toolbar does not have a real
id,but with a id named org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem
Bug
376254 - Manually adding to Workbench Modell
/ Calling E4Workbench.processHierarchy
Bug
389063 - Dynamic menu contribution call
back similar to Eclipse 3 org.ui.menus dynamic ContributionItem

Later,
PW

-- 
Paul Webster
Hi floor. Make me a sammich! - GIR_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev