[platform-ui-dev] Changes in Context Structure

[Douglas Pollock <douglas.pollock@xxxxxxxx>]

Hello,

I would like to change the context structure slightly.  The change is to 
support key bindings in dialogs.  I propose a new parenting structure:

+ org.eclipse.ui.contexts.dialogAndWindow
    + org.eclipse.ui.contexts.window
        + org.eclipse.ui.textEditorScope
            + org.eclipse.jdt.ui.javaEditorScope
        + Debugging
            + Debugging Java
    + org.eclipse.ui.contexts.dialog
        + Debugging Pop-ups

The workbench would be responsible for promoting and demoting the 
dialogAndWindow, window and dialog contexts.  There would be new semantic 
that these three special contexts have the ability to "block" their children 
from activating.  So, for example, if the "window" context is inactive, the 
"Debugging" context would be inactive as well.  This would all be handled 
transparently by the workbench.

"dialogAndWindow" would be active when either a window or a dialog is open.


I wish to commit these changes for M8.  These changes will break the semantic 
of existing contexts.  For example, if I committed the code without changes 
to "debug.ui/plugin.xml", all debugging keys would be active whenever the 
debug context is active -- regardless of whether a dialog is open or not.  
(Right now, key bindings never work in dialogs.)


Would you be willing to accept these changes?  Do you have comments, 
questions, queries, concerns?




d