Re: [platform-ui-dev] Patch: Task list filtering of resources in the sam

[Nick_Edgar@xxxxxxx]

Cagatay,

I have applied your patch and it will appear in today's integration build.

The only change I made was to resolve a conflict in the mnemonics in the 
dialog.  You had chosen &p for your item which conflicts with &priority.
I actually changed the priority item to priorit&y since I like to follow 
the heuristic that mnemonics earlier in a dialog use the more obvious 
choices for which letter to use.

The code looks good.  It's important to avoid unneeded refreshes, so I 
like the fact that it handles this properly when selecting different 
resources in the same project.
My only concern is with the code in TaskList.updateFocusResource, which 
does not handle a possibly null return value from resource.getProject() 
and focusResource.getProject().
getProject() can return null if the resource is the workspace root.  I 
know of no place in the UI where a workspace root is actually shown, 
however the code should handle this possibility (who knows what views will 
be written in the future)?  I can fix this up.

Congratulations!  You're the first person outside OTI/IBM to have a patch 
applied to the Eclipse UI component!

Nick





Nick Edgar
01/21/02 03:51 PM


        To:     platform-ui-dev@xxxxxxxxxxx
        cc: 
        Subject:        Re: [platform-ui-dev] Patch: Task list filtering of resources in the same 
project

Cagatay,

Thanks for the contribution.  I will check out your patch and get back to 
you.

Nick





"Cagatay Kavukcuoglu" <cagatayk@xxxxxxx>
Sent by: platform-ui-dev-admin@xxxxxxxxxxx
01/19/02 12:00 AM
Please respond to platform-ui-dev

 
        To:     <platform-ui-dev@xxxxxxxxxxx>
        cc: 
        Subject:        [platform-ui-dev] Patch: Task list filtering of resources in the same 
project


Hi,

I've attached a patch for org.eclipse.ui plugin. The patch implements an
additional resource filtering option in the task list. You can use this
to show all tasks in the project the selected resource is in. I've found
a few bug reports (2021, 5018) but none of them correspond to this
feature exactly as far as I can see. The patch works against the latest
source in CVS. It should also work against the 20020115 integration
build, there doesn't seem to be any difference.

Let me know what you think.

--
Cagatay