Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-ui-dev] Re: Action Enablement


The only useful "attributes" inherent to the IMarker interface for filtering are getType and isSubTypeOf
I would consider these to be "special" attributes and I think we should define a special attribute name for these.
The attributes defined on the IMarker interface ("done", "message", "priority", "severity") are all just standard attributes (accessed via getAttribute). I see no reason to distinguish between these and other attributes available (via getAttribute) in marker subtypes.

In fact if I look at MarkerActionFilter this is what we are already doing (see the list of keys a the bottom of this message). We just need to extend the set of valid "names" to include any attribute.




"David Springgay/OTT/OTI" <David_Springgay@xxxxxxx>
Sent by: platform-ui-dev-admin@xxxxxxxxxxx

11/29/01 03:11 PM
Please respond to platform-ui-dev

       
        To:        platform-ui-dev@xxxxxxxxxxx
        cc:        
        Subject:        Re: [platform-ui-dev] Re: Action Enablement



Given that these are "special attributes" of the marker, accessed by
calling getAttribute, do you think it is appropriate to prefix the
attribute id with a "special prefix" for accuracy?  This may reduce the
ambiguity between an attribute inherent to the IMarker interface, and those
retrieved via getAttribute.

IE: <filter name="getAttribute:xxx" value = "yyy"/>



                                                                                                           
                   "Randy Giffen/OTT/OTI"                                                                  
                   <Randy_Giffen@xxxxxxx>         To:     platform-ui-dev@xxxxxxxxxxx                      
                   Sent by:                       cc:                                                      
                   platform-ui-dev-admin@e        Subject:     Re: [platform-ui-dev] Re: Action Enablement
                   clipse.org                                                                              
                                                                                                           
                                                                                                           
                   11/29/01 09:49 AM                                                                      
                   Please respond to                                                                      
                   platform-ui-dev                                                                        
                                                                                                           
                                                                                                           




All attributes are of type String, Integer, or Boolean. They have some
convience methods to return an int or a boolean if you know the type is an
Integer or Boolean.
I was going to convert Integers and Booleans to Strings before comparing
them with the value in the XML.
So I didn't think any extra name prefix is required.

                                                                         
  "David Springgay/OTT/OTI"                                              
  <David_Springgay@xxxxxxx>                   To:                        
  Sent by:                            platform-ui-dev@xxxxxxxxxxx        
  platform-ui-dev-admin@xxxxxxxxxxx           cc:                        
                                              Subject:        Re:        
                                      [platform-ui-dev] Re: Action        
  11/29/01 09:30 AM                   Enablement                          
  Please respond to platform-ui-dev                                      
                                                                         





It looks like a marker attribute can be of type String, int, or boolean.
How do you plan to identify the attribute type and name in xml?  Would it
be something like this :

<filter name="intAttr:xxx" value = "999"/>
<filter name="stringAttr:yyy" value = "aaa"/>
<filter name="booleanAttr:zzz" value = "true | false"/>

Dave



                  "Randy Giffen/OTT/OTI"

                  <Randy_Giffen@xxxxxxx>         To:
platform-ui-dev@xxxxxxxxxxx
                  Sent by:                       cc:

                  platform-ui-dev-admin@e        Subject:     Re:
[platform-ui-dev] Re: Action Enablement
                  clipse.org



                  11/28/01 10:37 AM

                  Please respond to

                  platform-ui-dev







Karice and I are looking at F1 and "resolution" support for markers. In our
extension points for contributing F1 help context ids and resolution
classes we have to define a way of targeting a particular kind of marker.
This seems very similar to tarketing an action to a particular kind of
marker.

Curretly marker action targetting is based on the following keys:
DONE
MESSAGE
PRIORITY
SEVERITY
SUPER_TYPE
TYPE

Of these, SUPER_TYPE and TYPE are special, the remainer simply refer to
standard marker attributes.
I think we should extend marker filtering to be able to specify the value
any attribute.
Although we are still working out some details, I think this would allow us
to use the same extension point specification for marker F1 help, actions,
and resolutions.



_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-ui-dev





_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-ui-dev



Back to the top