Re: [platform-swt-dev] Theme patch. (read if you're not using Adwaita)

[Leo Ufimtsev <lufimtse@xxxxxxxxxx>]

On Tue, Apr 10, 2018 at 3:57 AM, Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:

Hi Leo,

I think I need to compile the natives for that to align the Java with
the native code. Is that correct? If yes, it would be nice to get this
Readme for how this can be done. See
https://bugs.eclipse.org/bugs/show_bug.cgi?id=533193

This particular patch doesn't require a rebuild of the natives.

Just checkout SWT & the binaries for your platform and checkout patch.

With that said, I plan on adding quick-start documentation for rebuilding natives this/next week.

(A comprehensive guide is around:
https://wiki.eclipse.org/SWT/Devel/Gtk/Dev_guide

But would benefit from update & making more concise).

 

Best regards, Lars

On Mon, Apr 9, 2018 at 5:20 PM, Leo Ufimtsev <Leonidas@xxxxxxxxxx> wrote:
> Hello SWT folks,
>
> We have a few Adwaita-specific hard-coded fixes in SWT (e.g deal with
> excessive padding in toolbar).
>
> I've written a patch that only applies Adwaita fixes if Adwaita is loaded:
> https://git.eclipse.org/r/#/c/120811/
>
> Thus improving some themes that were affected by the Adwaita-specific fixes.
> (e.g clearlook-phenix)
>
> This may affect your theme if your theme is a direct descendant of Adwaita
> on Gtk3.20+. If you're not using Adwaita, I encourage you to test & review
> the patch.
> (I briefly tried it with Ambiance [ubuntu theme], seemed to look ok).
>
> If there is no objections, I will merge the patch on Friday~ish.
>
> --
> Leo Ufimtsev, Software Engineer, Red Hat
>

> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-swt-dev



--
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
_______________________________________________
platform-swt-dev mailing list
platform-swt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev

--

Leo Ufimtsev, Software Engineer, Red Hat