Re: [platform-swt-dev] Patches for review

[Aleksandar Kurtakov <akurtako@xxxxxxxxxx>]

On Thu, Sep 28, 2017 at 10:05 AM, Thomas Singer <ts-swt@xxxxxxxxxxx> wrote:
> Hi Conrad,
>
> Thank you for your contributions.
>
>> The first one is waiting for review for 8 months now
>
>
> I know similar behavior from other open source projects (e.g. JGit) and I
> think, this is very discouraging for the contributors. Please review in
> reasonable time and either accept or reject it with a useful explanation.

I'm really sorry to hear such experience with one of the Platform
projects as personally I strive to change that as it's IMHO the most
important thing. Not to have current committers implement many cool
features, not to have timely reply on bugs but to review proposed
patches and grow some people to committers so we can work on the first
2 things together.
Niraj, as you're the win32 person, can we have these patches
prioritized? It would be nice to spend some time with Conrad and make
him a committer to unblock the win32 which can not progress as long as
you're the only person.
P.S. I would dare to say that this is not representative for SWT
project as a whole as e.g. the GTK specific patches are reviewed in
timely manner (down to zero unattended patches for this port, although
there are some in the queue just needing more work). Due to the
specific of the project it is impossible to review patches for WS one
has no idea for or even haven't seen it in years.

>
> --
> Best regards,
> Thomas Singer
> =============
> syntevo GmbH
> http://www.syntevo.com
> http://www.syntevo.com/blog
>
>
> On 27.09.2017 22:40, Conrad Groth wrote:
>>
>> I provided some patches for the SWT win32 implementation, that can be
>> reviewed:
>>
>>   <https://git.eclipse.org/r/#/c/87547/>
>> https://git.eclipse.org/r/#/c/87547/
>>
>> https://git.eclipse.org/r/#/c/99533/
>>
>> https://git.eclipse.org/r/#/c/100005/
>>
>> https://git.eclipse.org/r/#/c/105655/
>>
>>
>> The first one is waiting for review for 8 months now :(
>>
>> And it improves the dark theme on Windows.
>>
>>
>>
>>
>> _______________________________________________
>> platform-swt-dev mailing list
>> platform-swt-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>>
> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-swt-dev



-- 
Alexander Kurtakov
Red Hat Eclipse Team