Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-swt-dev] Backport a simple patch to 4.3

Hi Leo

https://bugs.eclipse.org/312451#c56captures it well. In addition, you will need a +1 from an SWT project lead in the bug report.

Dani



From:        Leo Ufimtsev <lufimtse@xxxxxxxxxx>
To:        "Eclipse Platform SWT component developers list." <platform-swt-dev@xxxxxxxxxxx>
Date:        06.10.2016 17:20
Subject:        [platform-swt-dev] Backport a simple patch to 4.3
Sent by:        platform-swt-dev-bounces@xxxxxxxxxxx




Hello,

I mentioned to an SWT user that I could potentially backport a simple null check patch to R4_3_maintenance, (He would do the building himself).

The reason for me to do it as oppose to him patching himself is that it would make licensing easier for them.

Then I found out that we normally don't backport that far back :-|.

Well, here was me trying to be nice.

As a one-off exception, in the interest of not disappointing the guy, would anyone mind if I merge back two simple null checks into R4_3_maintenance?

(The patches won't break anything, just very simple null checks that prevent gtk crashes).

312451: Accessible.addRelations should check if target == null

https://bugs.eclipse.org/bugs/show_bug.cgi?id=312451

Commits:
addRelation():

https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a31e66b6450374405a04b72f094dc49ee2c0846f
removeRelation():

https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=bad8a49cf9af35f6428be1c814c91fc9bb250c5f


If I don't hear any objections by October 11th, then I'll go ahead with the simple backport.

Thank you for your time.

---
Leo Ufimtsev | Software Engineer @ Red Hat
Email: Leonidas@xxxxxxxxxx
Phone: +1 647-467-3353
Blog: https://coffeeorientedprogramming.com/
Chat: https://mattermost.eclipse.org/eclipse/channels/platform-swt -> LeoUfimtsev
IRC:  freenode # swt 
Twitter: @LeoUfimtsev_______________________________________________
platform-swt-dev mailing list
platform-swt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev



Back to the top