Re: [platform-swt-dev] Removing non-JDK9 class from SWT

[Lakshmi P Shanmugam <lakshmipriya.bms@xxxxxxxxx>]

Hi Alex,

Sorry for the delayed response. I was away most of last week and couldn't respond to your mail or comment on the bug.

SWT_AWT bridge is broken with Java 9 + Jigsaw due to the dependencies on the JDK internal APIs. Running jdeps doesn't show all the dependencies as they are being called using reflection. Please see Bug 482318 for more details. I'll be trying out the proposal mentioned in comment 8 and making the required changes in SWT code. I'll mark your bug as depends on this bug as it should be fixed as part of the effort to fix the SWT_AWT bridge.

Thanks & Regards,

Lakshmi Shanmugam

On Fri, Apr 29, 2016 at 7:40 PM, Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote:

SWT team,

Can we make this change for Neon? It would be good to have an SWT JAR that isn’t going to throw any warnings when running against jdeps, especially since this will be the production version shipping when Java 9 launches.

Whether we can remove the temporary code or not is perhaps something we can defer to a future release but the review at https://git.eclipse.org/r/#/c/71104/ has been building successfully and is just waiting review.

Alex

On 23 Apr 2016, at 14:49, Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote:

I pushed a change to remove a static reference from a ComponentPeer (which has been removed in JDK9). Although the code is wrapped in a try/catch block (so it won’t error out at the moment anyway) the dependency shows up in a jdeps -jdkinternals scan which might be off-putting to some.

https://git.eclipse.org/r/#/c/71104/

With this change the functionality is preserved and the tool no longer shows up on the jdeps -jdkinternals scan.

However the block is in a piece of code which says:

* TEMPORARY CODE
*
* For some reason, the graphics configuration of the embedded
* frame is not initialized properly. This causes an exception
* when the depth of the screen is changed.

The alternative approach would be to delete the temporary code, which looks like it has been temporary for over a decade:

https://github.com/eclipse/eclipse.platform.swt/commit/33448e3818c41d50fcb95f5284f4135c600708fa

So another fix is to just remove this workaround if we believe it no longer has any value.

Can we get this resolved one way or another so that SWT won’t show up in a jdeps report? I’m happy to push a change which removes the temporary workaround if we think it’s no longer relevant.

Alex

_______________________________________________
platform-swt-dev mailing list
platform-swt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev

--

Lakshmi