Re: [platform-swt-dev] Contribution to review for styling of background

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

Hi Niraj,

thanks.

The patch is only ~50 lines of code, so I hope that this can be
reviewed before M7.

Best regards, Lars

On Thu, Apr 14, 2016 at 11:32 AM, Niraj Modi <niraj.modi@xxxxxxxxxx> wrote:
> Hi Lars/Conrad,
> Sure we will take a look at this, may be not immediately, but once we are
> done with current set of stuff.
>
> Regards,
> Niraj Modi
>
>
> From:        Lars Vogel <lars.vogel@xxxxxxxxxxx>
> To:        "Eclipse Platform SWT component developers list."
> <platform-swt-dev@xxxxxxxxxxx>
> Date:        04/14/2016 01:17 PM
> Subject:        [platform-swt-dev] Contribution to review for styling of
> background        color for buttons https://git.eclipse.org/r/70598
> Sent by:        platform-swt-dev-bounces@xxxxxxxxxxx
> ________________________________
>
>
>
> Dear SWT team,
>
> Conrad provide a contribution on the SWT level to allow styling the
> button background color.
>
> https://git.eclipse.org/r/70598
>
> This is a highly requested feature for the dark theme in Eclipse and
> we in Platform UI would like to improve the dark theme as much as
> possible. Also in one of the last PMC calls, the PMC discussed that,
> if possible, styling patches should be done as much as possible on the
> SWT level. The above patch is done on the SWT level.
>
> Could the SWT team therefore please review this patch with priority?
>
> Best regards, Lars
>
> P.S. This is also a bit personal, as I encouraged and explained Conrad
> how to created patches for the Eclipse project and I'm very happy that
> Conrad picked up SWT issues to fix, as not many contributors have the
> skills to fix SWT issues.
>
> --
> Eclipse Platform UI and e4 project co-lead
> CEO vogella GmbH
>
> Haindaalwisch 17a, 22395 Hamburg
> Amtsgericht Hamburg: HRB 127058
> Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
> USt-IdNr.: DE284122352
> Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web:
> http://www.vogella.com
>
> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>
>
> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-swt-dev



-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com