Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[platform-swt-dev] Regression in Composite background color machinery

Hello all,

I did a re-base this morning for one of my older branches and noticed that the commit:

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=14734beab7b7b915783fb9d21c16ed3bd253062b

re-introduces some old background color code in Composite. Seems to be a one-off, I checked the rest of the commit and it seems fine. Unfortunately this is a regression as ToolBar background color tests fail now with this change. This will also affect getBackground() functionality for children of Composite.

I know M6 is out today, but I have a fix available:
https://git.eclipse.org/r/#/c/68773/

I think it would be worth it to include it since M6 has lots of positive changes that shouldn't be overshadowed by any regressions.

Let me know your thoughts.

Thanks,
--
Eric Williams
Software Engineering Intern, Eclipse Team


Back to the top