Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-swt-dev] SWT GTK Theme

Yes, that is fine



From:        Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
To:        "Eclipse Platform SWT component developers list." <platform-swt-dev@xxxxxxxxxxx>,
Date:        10/16/2012 05:20 PM
Subject:        Re: [platform-swt-dev] SWT GTK Theme
Sent by:        platform-swt-dev-bounces@xxxxxxxxxxx




There were *only* warnings, I compiled it prior to sending. So http://fedorapeople.org/cgit/akurtakov/public_git/eclipse.platform.swt.git/commit/?h=no_gtk3_theme&id=c5bef6ffc26b1d46a9d1e3a45447fccfbfbc609d is fine?

Alexander Kurtakov
Red Hat Eclipse team

----- Original Message -----
> From: "Silenio Quarti" <Silenio_Quarti@xxxxxxxxxx>
> To: "Eclipse Platform SWT component developers list." <platform-swt-dev@xxxxxxxxxxx>
> Sent: Tuesday, October 16, 2012 11:56:14 PM
> Subject: Re: [platform-swt-dev] SWT GTK Theme
>
>
> I did not try, but I think this would cause compilation errors
> because of the missing casts (when compiling against GTK 2).
>
> It would be better if we removed the native completely if
> GTK_VERSION>=3.0.0.
>
> Add something like below to os.h:
>
> if GTK_CHECK_VERSION(3,0,0)
> #define NO__1gtk_1style_1get_1bg_1gc
> ... etc
> #endif
>
>
>
>
>
> From: Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
> To: "Eclipse Platform SWT component developers list."
> <platform-swt-dev@xxxxxxxxxxx>,
> Date: 10/16/2012 04:42 PM
> Subject: Re: [platform-swt-dev] SWT GTK Theme
> Sent by: platform-swt-dev-bounces@xxxxxxxxxxx
>
>
>
>
> Silenio,
> Are you fine with pushing this commit
>
http://fedorapeople.org/cgit/akurtakov/public_git/eclipse.platform.swt.git/commit/?h=no_gtk3_theme&id=cd90b3c1169e44514850aa3f57a270bea62b0d55
> then ?
>
> Alexander Kurtakov
> Red Hat Eclipse team
>
> ----- Original Message -----
> > From: "Silenio Quarti" <Silenio_Quarti@xxxxxxxxxx>
> > To: "Eclipse Platform SWT component developers list."
> > <platform-swt-dev@xxxxxxxxxxx>
> > Sent: Tuesday, October 16, 2012 9:39:41 PM
> > Subject: Re: [platform-swt-dev] SWT GTK Theme
> >
> >
> > I think we should eventually do the work to port it, but it is very
> > low priority in my opinion.
> >
> > Silenio
> >
> >
> >
> > From: Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
> > To: "Eclipse Platform SWT component developers list."
> > <platform-swt-dev@xxxxxxxxxxx>,
> > Date: 10/16/2012 01:46 PM
> > Subject: Re: [platform-swt-dev] SWT GTK Theme
> > Sent by: platform-swt-dev-bounces@xxxxxxxxxxx
> >
> >
> >
> >
> > In this case can we drop it or at least not compile it by default?
> > It
> > doesn't make sense to me to spend time porting something unfinished
> > and not in the works lately?
> >
> > Alexander Kurtakov
> > Red Hat Eclipse team
> >
> > ----- Original Message -----
> > > From: "Silenio Quarti" <Silenio_Quarti@xxxxxxxxxx>
> > > To: "Eclipse Platform SWT component developers list."
> > > <platform-swt-dev@xxxxxxxxxxx>
> > > Sent: Tuesday, October 16, 2012 7:28:17 PM
> > > Subject: Re: [platform-swt-dev] SWT GTK Theme
> > >
> > >
> > > The org.eclipse.swt.internal.theme package is an attempt to
> > > provide
> > > Theme drawing APIs so that custom widgets could draw portions of
> > > its
> > > content with native look (buttons, checkboxes, scrollbars. etc).
> > > The
> > > code was never finalized, so the API was never moved into a
> > > public
> > > package. The package was exported in order for the community to
> > > try
> > > it out. It seems that the interest on such API faded away and it
> > > never got high priority to get finished.
> > >
> > > I am not aware of anyone using it. It is certainly not used by
> > > the
> > > Eclipse SDK.
> > >
> > > Silenio
> > >
> > >
> > >
> > > From: Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
> > > To: "Eclipse Platform SWT component developers list."
> > > <platform-swt-dev@xxxxxxxxxxx>,
> > > Date: 10/15/2012 05:11 PM
> > > Subject: [platform-swt-dev] SWT GTK Theme
> > > Sent by: platform-swt-dev-bounces@xxxxxxxxxxx
> > >
> > >
> > >
> > >
> > > Hi everyone,
> > >
> > > Can someone give me some overview of how
> > > org.eclipse.swt.internal.theme is supposed to be used. It makes
> > > use
> > > of a number of things removed in GTK3 but I don't find any usage
> > > in
> > > SWT itself and the internal package is exported which made me a
> > > bit
> > > suspicious. What's the story with it?
> > >
> > > Alexander Kurtakov
> > > Red Hat Eclipse team
> > >
> > > _______________________________________________
> > > platform-swt-dev mailing list
> > > platform-swt-dev@xxxxxxxxxxx
> > >
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
> > >
> > >
> > >
> > > _______________________________________________
> > > platform-swt-dev mailing list
> > > platform-swt-dev@xxxxxxxxxxx
> > >
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
> > >
> > _______________________________________________
> > platform-swt-dev mailing list
> > platform-swt-dev@xxxxxxxxxxx
> >
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
> >
> >
> >
> > _______________________________________________
> > platform-swt-dev mailing list
> > platform-swt-dev@xxxxxxxxxxx
> >
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
> >
> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
>
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>
>
>
> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
>
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>
_______________________________________________
platform-swt-dev mailing list
platform-swt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev



Back to the top