Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-swt-dev] Welcome Alexander Kurtakov as a new eclipse.platform.swt Committer

Hi Alex and welcome.

Unfortunately, we do not have a New Contributors page and we would appreciate if you started one.

Here are a couple a things that come to me in adding to what you have mentioned:

1) Code formatting. We have never been able to use the Eclipse's code formatter to enforce the same formatting in the SWT code.  Believe me, we have talked about it at least a couple of times and decided against. This means that we rely on every committer to try to keep the formatting the same with the code being changed.

2) Be really careful with the 32/64 bit code pre-processing.  Our automated build and the SWT tools catch quite a bit of problems, but they miss cases. Unfortunately these cases can go unnoticed for quite same time. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=390713 for an example.

3) When the code is really odd or is working around a problem in the underlining toolkit. Add a comment indicating it  You will see this all over the code, It really helps specially if you have been around for a long time like SWT is.

Silenio



From:        Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
To:        "Eclipse Platform SWT component developers list." <platform-swt-dev@xxxxxxxxxxx>,
Date:        09/24/2012 01:36 AM
Subject:        Re: [platform-swt-dev] Welcome Alexander Kurtakov as a        new        eclipse.platform.swt Committer
Sent by:        platform-swt-dev-bounces@xxxxxxxxxxx




Thanks everyone,

It's an honour for me. Before doing anything I want to be sure that I would follow the procedures that SWT committers obey to. Is there some page for helping newcomers? Things like - first open a bug and refer to it into commit message, even if you are committer your patch has to be reviewed by another committer first, etc. If there is no such page(I failed to find one) I'm volunteering to start such a page with what I know and information I get as replies.
http://wiki.eclipse.org/SWT/NewContributor sounds good ?
Also are there some things from the 4.3 plan[1] that everyone is expected to spend time on?
Please reply with anything that comes to your mind.

P.S. I'm on vacation this week so no fast replies.

[1]
http://wiki.eclipse.org/SWT/Plan4.3

Alexander Kurtakov
Red Hat Eclipse team

----- Original Message -----
> From: "portal on behalf of Silenio Quarti" <Silenio_Quarti@xxxxxxxxxx>
> To: platform-swt-dev@xxxxxxxxxxx
> Sent: Friday, September 21, 2012 4:42:02 PM
> Subject: [platform-swt-dev] Welcome Alexander Kurtakov as a new                 eclipse.platform.swt Committer
>
> eclipse.platform.swt Committers,
> This automatically generated message marks the completion of all the
> legal
> paperwork and webmaster provisioning for Alexander Kurtakov.
> Alexander
> Kurtakov is a new full Committer on the eclipse.platform.swt project.
>
> Welcome!
> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
>
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>
_______________________________________________
platform-swt-dev mailing list
platform-swt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev



Back to the top